From ff3f7a25853009121e6a5ee1657b7fca63dfc4c5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 11 Feb 2021 11:49:54 +0100 Subject: [PATCH] Bug 22824: Correct on/off behaviour Here things are starting to be a bit tricky. IMO we don't want to replicate the ImplicitTyping behaviour from YAML::Syck but handle correctly the different value. We have the list of available values in the .pref file, the values in DB must match them. We want 1 or 0 in DB. 2 more occurrences: finesMode => Dealt on bug 27676 ('off' is ok here) itemBarcodeInputFilter => 'OFF' is correct here Note that we don't use ~ or true/false in *.pref Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice --- .../en/modules/admin/preferences/logs.pref | 72 +++++++++---------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref index 2d717fc165..490a69569d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref @@ -3,110 +3,110 @@ Logging: - - pref: LetterLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when an automatic claim notice is sent. - - pref: BorrowersLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - changes to patron records. - - pref: CataloguingLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - any changes to bibliographic or item records. - - pref: AuthoritiesLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - changes to authority records. - - pref: FinesLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when fines are charged, paid, or forgiven. - - pref: HoldsLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - any actions on holds (create, cancel, suspend, resume, etc). - - pref: IllLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when changes to ILL requests take place. - - pref: IssueLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when items are checked out. - - pref: ReturnLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when items are checked in. - - pref: RenewalLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when items are renewed. - - pref: SubscriptionLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when serials are added, deleted or changed. - - pref: CronjobLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - information from cron jobs. - - pref: ReportsLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - when reports are added, deleted or changed. - - pref: AuthFailureLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - " authentication failures." - - pref: AuthSuccessLog choices: - on: Log - off: "Don't log" + 1: Log + 0: "Don't log" - " successful authentications." Debugging: - - pref: DumpTemplateVarsIntranet choices: - on: Do - off: "Don't" + 1: Do + 0: "Don't" - dump all Template Toolkit variables to a comment in the HTML source for the staff interface. - - pref: DumpTemplateVarsOpac choices: - on: Do - off: "Don't" + 1: Do + 0: "Don't" - dump all Template Toolkit variables to a comment in the HTML source for the OPAC. - - pref: DumpSearchQueryTemplate choices: - on: Do - off: "Don't" + 1: Do + 0: "Don't" - dump search query as a template parameter, requires DumpTemplateVars[interface] to be visible. -- 2.20.1