Bugzilla – Attachment 117118 Details for
Bug 27715
Possibly SQL injection in virtualshelves
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27715: (QA follow-up) Remove conditional declaration
Bug-27715-QA-follow-up-Remove-conditional-declarat.patch (text/plain), 1.01 KB, created by
Marcel de Rooy
on 2021-02-20 09:59:10 UTC
(
hide
)
Description:
Bug 27715: (QA follow-up) Remove conditional declaration
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-02-20 09:59:10 UTC
Size:
1.01 KB
patch
obsolete
>From c2137d95bf5cf81b56c5c6e38303e45130672763 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Sat, 20 Feb 2021 09:57:20 +0000 >Subject: [PATCH] Bug 27715: (QA follow-up) Remove conditional declaration >Content-Type: text/plain; charset=utf-8 > >Resolves: >FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Utils/DataTables.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/C4/Utils/DataTables.pm b/C4/Utils/DataTables.pm >index 23c7ebd405..6e1af15611 100644 >--- a/C4/Utils/DataTables.pm >+++ b/C4/Utils/DataTables.pm >@@ -116,8 +116,7 @@ sub dt_build_orderby { > push @sanitized_orderbys, "$sanitized_identifier $sanitized_direction"; > } > >- my $orderby = " ORDER BY " . join(',', @sanitized_orderbys) . " " if @sanitized_orderbys; >- return $orderby; >+ return " ORDER BY " . join(',', @sanitized_orderbys) . " " if @sanitized_orderbys; > } > > =head2 dt_get_params >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27715
:
116992
|
116993
|
116994
|
116995
|
116998
|
117027
|
117028
|
117029
|
117030
|
117031
|
117032
|
117033
|
117034
|
117035
|
117036
|
117068
|
117069
|
117070
|
117071
|
117072
|
117073
|
117074
|
117076
|
117077
|
117078
|
117079
|
117080
|
117081
|
117082
|
117112
|
117113
|
117114
|
117115
|
117116
|
117117
| 117118