Bugzilla – Attachment 117367 Details for
Bug 25777
Datatables on z3950_search.pl show incorrect number of entries
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25777: Disable misleading datatables table information display z3950
Bug-25777-Disable-misleading-datatables-table-info.patch (text/plain), 2.98 KB, created by
Martin Renvoize
on 2021-02-26 08:58:45 UTC
(
hide
)
Description:
Bug 25777: Disable misleading datatables table information display z3950
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2021-02-26 08:58:45 UTC
Size:
2.98 KB
patch
obsolete
>From 8898cc010c564e408e89e2a531434c13a42bcd14 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 17 Jun 2020 04:34:02 +0000 >Subject: [PATCH] Bug 25777: Disable misleading datatables table information > display z3950 > >This patch disables the table information display on z3950_search.pl, >since it only includes search result counts for that page, which is >misleading to end users. > >To test: >1) Do not apply the patch >2) Do a Z39.50 search from cataloguing for "test" against Library of > Congress. >3) Note the bottom of the page says "Show 1 to 20 of 20" and > "Showing page 1 of 501" >4) Do a Z39.50 search from Acquisitions for "test" against Library of > Congress (Acquisitions -> Vendor -> Basket -> Add to basket -> From > external source). >5) Apply the patch and restart Plack >6) Repeat Step #2 >7) Note the bottom of the page now only says "Showing page 1 of 501" >8) Note the search bar is gone >9) Repeat step #4 >10) Note the bottom of the page now only says "Showing page 1 of 501" >11) Note the search bar is gone > >Squashed and mixed authorship added below >Co-authored-by: Owen Leonard <oleonard@myacpl.org> >Co-authored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 4 +++- > .../intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >index fe2e0b3d93..b474f1dc74 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >@@ -235,7 +235,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > { "aTargets": [ 1 ], "sType": "nsb-nse" }, > ], > "aaSorting": [[ 1, "asc" ]], >- "bPaginate": false >+ "bPaginate": false, >+ "searching": false, >+ "bInfo":false > })); > InitLastAction(); > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 088b4dafa4..228e94c2d7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -246,7 +246,9 @@ > { "aTargets": [ 1 ], "sType": "nsb-nse" }, > ], > "aaSorting": [[ 1, "asc" ]], >- "bPaginate": false >+ "bPaginate": false, >+ "searching": false, >+ "bInfo":false > }, columns_settings ); > InitLastAction(); > }); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25777
:
105933
|
115626
|
115787
|
115788
|
116269
|
116270
|
116306
|
116307
|
116391
| 117367