From 0635a473e994131a7d015eb605640ed645ac404e Mon Sep 17 00:00:00 2001
From: Agustin Moyano <agustinmoyano@theke.io>
Date: Wed, 28 Oct 2020 10:48:09 -0300
Subject: [PATCH] Bug 24359: Add test

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 t/db_dependent/HoldsQueue.t | 67 +++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t
index 4ffac93358d..20936fb5d44 100755
--- a/t/db_dependent/HoldsQueue.t
+++ b/t/db_dependent/HoldsQueue.t
@@ -14,6 +14,7 @@ use Data::Dumper;
 use C4::Calendar;
 use C4::Context;
 use C4::Members;
+use C4::Circulation;
 use Koha::Database;
 use Koha::DateUtils;
 use Koha::Items;
@@ -1657,3 +1658,69 @@ sub dump_records {
     my ($tablename) = @_;
     return $dbh->selectall_arrayref("SELECT * from $tablename where borrowernumber = ?", { Slice => {} }, $borrowernumber);
 }
+
+subtest 'Remove holds on check-in match' => sub {
+    plan tests => 2;
+
+    $schema->storage->txn_begin;
+
+    $dbh->do('DELETE FROM tmp_holdsqueue');
+    $dbh->do('DELETE FROM hold_fill_targets');
+
+    my $lib = $builder->build_object( { class => 'Koha::Libraries' } );
+
+    my $patron1 = $builder->build_object(
+        {
+            class => 'Koha::Patrons',
+            value => { branchcode => $lib->branchcode }
+        }
+    );
+    my $patron2 = $builder->build_object(
+        {
+            class => 'Koha::Patrons',
+            value => { branchcode => $lib->branchcode }
+        }
+    );
+
+    my $item = $builder->build_sample_item(
+        { homebranch => $lib->branchcode, holdingbranch => $lib->branchcode } );
+
+    t::lib::Mocks::mock_userenv( { branchcode => $lib->branchcode } );
+
+    AddIssue( $patron1->unblessed, $item->barcode, dt_from_string );
+
+    my $hold_id = AddReserve(
+        {
+            branchcode     => $item->homebranch,
+            borrowernumber => $patron2->borrowernumber,
+            biblionumber   => $item->biblionumber,
+            itemnumber     => undef,
+            priority       => 1
+        }
+    );
+
+    my $hold = Koha::Holds->find($hold_id);
+
+    AddReturn( $item->barcode, $item->homebranch );
+
+    C4::HoldsQueue::CreateQueue();
+
+    my $sth = $dbh->prepare("SELECT count(*) FROM tmp_holdsqueue");
+    $sth->execute();
+    my ($count_1) = $sth->fetchrow_array;
+
+    is( $count_1, 1, "Holds queue has one element" );
+
+    AddReturn( $item->barcode, $item->homebranch, undef, dt_from_string );
+
+    ModReserveAffect( $item->itemnumber, $hold->borrowernumber, 0,
+        $hold->reserve_id );
+
+    $sth->execute();
+    my ($count_2) = $sth->fetchrow_array;
+
+    is( $count_2, 0,
+        "Holds queue has no elements, even when queue was not rebuilt" );
+
+    $schema->storage->txn_rollback;
+};
-- 
2.30.1