Bugzilla – Attachment 117538 Details for
Bug 26247
Search terms retained in header search creates UX inconsistency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26247: Make search terms optionally sticky
Bug-26247-Make-search-terms-optionally-sticky.patch (text/plain), 4.31 KB, created by
ByWater Sandboxes
on 2021-03-02 16:52:20 UTC
(
hide
)
Description:
Bug 26247: Make search terms optionally sticky
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2021-03-02 16:52:20 UTC
Size:
4.31 KB
patch
obsolete
>From 64dc7f19d761f35e124683365fea0c54bb4e7ff7 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Sun, 28 Feb 2021 16:18:45 +0000 >Subject: [PATCH] Bug 26247: Make search terms optionally sticky > >This patch adds a configurable option for retaining stickiness of search terms >across search tabs > >To test: >1 - Apply all patches except this one, enable StaffRetainSearchTerms >2 - Search in staff client from header >3 - Confirm behaviour is that term is retained, but not copied when switching header search tab >4 - Apply this patch, updatedatabase >5 - Search again >6 - Previous behaviour is restored, search terms are sticky between tabs >7 - Disable preference StaffStickySearchTerms >8 - Search again >9 - Search terms retained, but not sticky > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > installer/data/mysql/mandatory/sysprefs.sql | 1 + > koha-tmpl/intranet-tmpl/prog/en/includes/catalog-search-box.inc | 4 ++++ > .../intranet-tmpl/prog/en/modules/admin/preferences/searching.pref | 7 +++++++ > 3 files changed, 12 insertions(+) > >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index d20597566e..ef34e92078 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -626,6 +626,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('StaffRetainSearchTerms', '1', NULL, 'If enabled, searches entered into the search bar will be retained', 'YesNo'), > ('StaffSearchResultsDisplayBranch','holdingbranch','holdingbranch|homebranch','Controls the display of the home or holding branch for staff search results','Choice'), > ('StaffSerialIssueDisplayCount','3','','Number of serial issues to display per subscription in the staff interface','Integer'), >+('StaffStickySearchTerms', '1', NULL, 'If enabled, searches entered into the search bar will be copied to other header tabs', 'YesNo'), > ('StaticHoldsQueueWeight','0',NULL,'Specify a list of library location codes separated by commas -- the list of codes will be traversed and weighted with first values given higher weight for holds fulfillment -- alternatively, if RandomizeHoldsQueueWeight is set, the list will be randomly selective','Integer'), > ('StatisticsFields','location|itype|ccode', NULL, 'Define Fields (from the items table) used for statistics members','Free'), > ('StockRotation','0',NULL,'If ON, enables the stock rotation module','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/catalog-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/catalog-search-box.inc >index 7eca35f0b1..88453ac250 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/catalog-search-box.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/catalog-search-box.inc >@@ -7,7 +7,11 @@ > [% ELSE %] > <label class="tip" for="search-form">Enter search keywords:</label> > [% END %] >+ [% IF ( Koha.Preference('StaffStickySearchTerms') ) %] >+ <input type="text" name="q" id="search-form" size="40" value="[% ms_value | html %]" title="Enter the terms you wish to search for." class="head-searchbox sticky form-text" /> >+ [% ELSE %] > <input type="text" name="q" id="search-form" size="40" value="[% ms_value | html %]" title="Enter the terms you wish to search for." class="head-searchbox form-text" /> >+ [% END %] > <input type="submit" value="Submit" class="submit" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >index fc40ab7b52..5babcaba9c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >@@ -268,6 +268,13 @@ Searching: > no: "don't retain" > - search terms between searches. > - >+ - When searching from the header in the staff client >+ - pref: StaffStickySearchTerms >+ choices: >+ yes: "copy" >+ no: "don't copy" >+ - search terms between search tabs. >+ - > - pref: BiblioItemtypeInfo > choices: > yes: "Display" >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26247
:
117408
|
117409
|
117410
|
117411
|
117461
|
117535
|
117536
|
117537
|
117538
|
117539
|
120353
|
120354
|
120355
|
120356
|
120357
|
120358
|
120359
|
120360
|
136683
|
136767
|
137310
|
138478
|
140473
|
140474