From d670459cd91f69fbaf9883a5b20f5e0fe9cd10f8 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 22 Feb 2021 12:50:55 +0000 Subject: [PATCH] Bug 24446: (QA follow-up) Update unit test for ModItemTransfer Update unit test to reflect we now use cancellationdate and cancellation_reason in ModItemTransfer --- t/db_dependent/Items.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index a5e4a52919..a6a45bf925 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -146,7 +146,7 @@ subtest 'ModItemTransfer tests' => sub { ); ModItemTransfer( $item->itemnumber, $library1->{branchcode}, - $library2->{branchcode} ); + $library2->{branchcode}, 'Manual' ); my $transfers = Koha::Item::Transfers->search( { @@ -159,7 +159,7 @@ subtest 'ModItemTransfer tests' => sub { is($item->holdingbranch, $library1->{branchcode}, "Items holding branch was updated to frombranch"); ModItemTransfer( $item->itemnumber, $library2->{branchcode}, - $library1->{branchcode} ); + $library1->{branchcode}, 'Manual' ); $transfers = Koha::Item::Transfers->search( { itemnumber => $item->itemnumber, }, { order_by => { '-asc' => 'branchtransfer_id' } } @@ -168,8 +168,8 @@ subtest 'ModItemTransfer tests' => sub { is($transfers->count, 2, "Second transfer recorded on second call of ModItemTransfer"); my $transfer1 = $transfers->next; my $transfer2 = $transfers->next; - isnt($transfer1->datearrived, undef, "First transfer marked as completed by ModItemTransfer"); - like($transfer1->comments,qr/^Canceled/, "First transfer contains 'Canceled' comment"); + isnt($transfer1->datecancelled, undef, "First transfer marked as cancelled by ModItemTransfer"); + like($transfer1->cancellation_reason,qr/^Manual/, "First transfer contains cancellation_reason 'Manual'"); is($transfer2->datearrived, undef, "Second transfer is now the active transfer"); $item->discard_changes; is($item->holdingbranch, $library2->{branchcode}, "Items holding branch was updated to frombranch"); -- 2.20.1