From b2aa3d0afe0117553f4e8c2aeb6a8abd60141228 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 2 Mar 2021 11:10:12 -0300 Subject: [PATCH] Bug 27833: Make K::P::Attribute add the object to the exception This patch makes the 'check_unique_id' and '_check_repeatable' methods pass the 'attribute' parameter when throwing an exception. This way we can provid emore meaningfull error messages. To test: 1. Apply the previous patches 2. Run $ kshell k$ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: The exceptions are not passed the attribute! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- Koha/Patron/Attribute.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/Patron/Attribute.pm b/Koha/Patron/Attribute.pm index 5afd674149..3e23a268e2 100644 --- a/Koha/Patron/Attribute.pm +++ b/Koha/Patron/Attribute.pm @@ -133,7 +133,7 @@ sub _check_repeatable { code => $self->code } )->count; - Koha::Exceptions::Patron::Attribute::NonRepeatable->throw() + Koha::Exceptions::Patron::Attribute::NonRepeatable->throw( attribute => $self ) if $attr_count > 0; } @@ -161,7 +161,7 @@ sub check_unique_id { my $unique_count = Koha::Patron::Attributes ->search( $params ) ->count; - Koha::Exceptions::Patron::Attribute::UniqueIDConstraint->throw() + Koha::Exceptions::Patron::Attribute::UniqueIDConstraint->throw( attribute => $self ) if $unique_count > 0; } -- 2.20.1