Bugzilla – Attachment 117865 Details for
Bug 27058
Cannot place hold to ordered item when on shelf holds are not allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27058: (follow-up) Clarify notforloan checks with a comment
Bug-27058-follow-up-Clarify-notforloan-checks-with.patch (text/plain), 1.60 KB, created by
Joonas Kylmälä
on 2021-03-05 15:31:30 UTC
(
hide
)
Description:
Bug 27058: (follow-up) Clarify notforloan checks with a comment
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-03-05 15:31:30 UTC
Size:
1.60 KB
patch
obsolete
>From 00cb9afdb7ca21b5ddc604f7aa85a0e56d89e908 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Fri, 5 Mar 2021 17:26:02 +0200 >Subject: [PATCH] Bug 27058: (follow-up) Clarify notforloan checks with a > comment > >In IsAvailableForItemLevelRequest the check is for holdability and in >ItemsAnyAvailableAndNotRestricted the check is for >checkoutability. These comments should make it more clear because the >notforloan value is used for these two different purposes and is a bit >confusing (we might want to add a new field "notforhold" in future to >make the code self documenting) >--- > C4/Reserves.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 75a978b4a6..e27b30e6a2 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1312,7 +1312,7 @@ sub IsAvailableForItemLevelRequest { > return 0 if > $notforloan_per_itemtype || > $item->itemlost || >- $item->notforloan > 0 || >+ $item->notforloan > 0 || # item with negative or zero notforloan value is holdable > $item->withdrawn || > ($item->damaged && !C4::Context->preference('AllowHoldsOnDamagedItems')); > >@@ -1373,7 +1373,7 @@ sub ItemsAnyAvailableAndNotRestricted { > # we can return (end the loop) when first one found: > return 1 > unless $i->itemlost >- || $i->notforloan >+ || $i->notforloan # items with non-zero notforloan cannot be checked out > || $i->withdrawn > || $i->onloan > || IsItemOnHoldAndFound( $i->id ) >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27058
:
113820
|
113821
|
113822
|
113824
|
113825
|
114203
|
114204
|
114210
|
114211
|
117021
|
117780
|
117781
|
117782
|
117855
|
117864
| 117865