Bugzilla – Attachment 11789 Details for
Bug 2553
alphabetize dropdown menus
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 2553 [Serials report] alphabetize dropdown menus
SIGNED-OFF-Bug-2553-Serials-report-alphabetize-dro.patch (text/plain), 3.24 KB, created by
Nicole C. Engard
on 2012-08-23 14:17:30 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 2553 [Serials report] alphabetize dropdown menus
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2012-08-23 14:17:30 UTC
Size:
3.24 KB
patch
obsolete
>From 04acd0fef09df60cb6f9d902bb8d83c0b4168c87 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 Aug 2012 10:08:27 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 2553 [Serials report] alphabetize dropdown menus > >Rebase of a patch originally submitted by gcollum@gmail.com >Original commit message: > >Improvement on the previous patch through the use of GetBranchesLoop. >Added code so that the logged in location will be the location that >is selected by default. > >Fixed a couple of minor xhtml errors. > >Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> >--- > .../prog/en/modules/reports/serials_stats.tt | 12 ++++++++---- > reports/serials_stats.pl | 16 ++-------------- > 2 files changed, 10 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >index c42bc45..af51a4c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >@@ -73,20 +73,24 @@ > [% END %] > </select> > </li><li> >- <label for="branch"> >+ <label for="branchcode"> > Library: > </label> > <select name="branchcode" id="branchcode"> > <option value="">Any library</option> >- [% FOREACH branche IN branches %] >- <option value="[% branche.branchcode %]">[% branche.branchname %]</option> >+ [% FOREACH branche IN branches %] >+ [% IF ( branche.selected ) %] >+ <option value="[% branche.value %]" selected="selected">[% branche.branchname %]</option> >+ [% ELSE %] >+ <option value="[% branche.value %]">[% branche.branchname %]</option> >+ [% END %] > [% END %] > </select> > > </li> > <li> > <label for="expired">Include expired subscriptions: </label> >- <input type="checkbox" name="expired" /> >+ <input type="checkbox" name="expired" id="expired" /> > </li> > </ol> > </fieldset> >diff --git a/reports/serials_stats.pl b/reports/serials_stats.pl >index ff80b2f..9aff54b 100755 >--- a/reports/serials_stats.pl >+++ b/reports/serials_stats.pl >@@ -140,19 +140,7 @@ if($do_it){ > while(my $row = $sth->fetchrow_hashref){ > push(@booksellers,$row) > } >- >- ## We generate branchlist >- my $branches=GetBranches(); >- my @branchloop; >- foreach (sort {$branches->{$a}->{'branchname'} cmp $branches->{$b}->{'branchname'}} keys %$branches) { >- my $thisbranch = ''; # FIXME: populate $thisbranch to preselect one >- my %row = (branchcode => $_, >- selected => ($thisbranch eq $_ ? 1 : 0), >- branchname => $branches->{$_}->{'branchname'}, >- ); >- push @branchloop, \%row; >- } >- >+ > my $CGIextChoice=CGI::scrolling_list( > -name => 'MIME', > -id => 'MIME', >@@ -164,7 +152,7 @@ if($do_it){ > CGIextChoice => $CGIextChoice, > CGIsepChoice => $CGIsepChoice, > booksellers => \@booksellers, >- branches => \@branchloop); >+ branches => GetBranchesLoop(C4::Context->userenv->{'branch'})); > } > > output_html_with_http_headers $input, $cookie, $template->output; >-- >1.7.2.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 2553
:
721
|
722
|
723
|
724
|
725
|
726
|
727
|
728
|
729
|
730
|
731
|
732
|
733
|
11788
| 11789