@@ -, +, @@ --- t/db_dependent/Koha/Hold.t | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/t/db_dependent/Koha/Hold.t +++ a/t/db_dependent/Koha/Hold.t @@ -143,7 +143,7 @@ subtest 'set_pickup_location() tests' => sub { subtest 'is_pickup_location_valid() tests' => sub { - plan tests => 4; + plan tests => 5; $schema->storage->txn_begin; @@ -196,5 +196,11 @@ subtest 'is_pickup_location_valid() tests' => sub { ok( !$item_hold->is_pickup_location_valid({ library_id => $library_1->branchcode }), 'Pickup location invalid'); ok( $item_hold->is_pickup_location_valid({ library_id => $library_2->id }), 'Pickup location valid' ); + # let's mock what Koha::Item->pickup_locations returns, for testing + $mock_item->mock( 'pickup_locations', sub { + return Koha::Libraries->new()->empty; + }); + ok( !$item_hold->is_pickup_location_valid({ library_id => $library_2->id }), 'Pickup location invalid' ); + $schema->storage->txn_rollback; }; --