From b992c5940633fb6d2564f13c8e471e2abb0b6f3c Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Date: Wed, 10 Mar 2021 17:33:26 +0000 Subject: [PATCH] Bug 15563: add option to cleanup_database to delete old label and card batches To test: For item label batches: 1- Create 3 item label batches of at least 2 items each 2- Perform the following updates via the database 3- In Batch 1, set all items' timestamps to 10+ days prior to today 4- In Batch 2, set 1 item's timestamp to 10+ days prior to today 5- In Batch 3, do not update any timestamps 6- Run cron with --labels 9 7- Confirm batch 1 is deleted, batches 2 and 3 are not Repeat with card creator batches 8- Create 3 card creator batches of at least 2 items each 9- Perform the following updates via the database 10- In Batch 1, set all cards' timestamps to 10+ days prior to today 11- In Batch 2, set 1 card's timestamp to 10+ days prior to today 12- In Batch 3, do not update any timestamps 13- Run cron with --cards 9 14- Confirm batch 1 is deleted, batches 2 and 3 are not Signed-off-by: Abbey Holt <aholt@dubuque.lib.ia.us> --- misc/cronjobs/cleanup_database.pl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl index 78cbd6057f..4631ebbe2a 100755 --- a/misc/cronjobs/cleanup_database.pl +++ b/misc/cronjobs/cleanup_database.pl @@ -55,7 +55,7 @@ use Koha::Patron::Messages; sub usage { print STDERR <<USAGE; -Usage: $0 [-h|--help] [--confirm] [--sessions] [--sessdays DAYS] [-v|--verbose] [--zebraqueue DAYS] [-m|--mail] [--merged] [--import DAYS] [--logs DAYS] [--searchhistory DAYS] [--restrictions DAYS] [--all-restrictions] [--fees DAYS] [--temp-uploads] [--temp-uploads-days DAYS] [--uploads-missing 0|1 ] [--statistics DAYS] [--deleted-catalog DAYS] [--deleted-patrons DAYS] [--old-issues DAYS] [--old-reserves DAYS] [--transfers DAYS] +Usage: $0 [-h|--help] [--confirm] [--sessions] [--sessdays DAYS] [-v|--verbose] [--zebraqueue DAYS] [-m|--mail] [--merged] [--import DAYS] [--logs DAYS] [--searchhistory DAYS] [--restrictions DAYS] [--all-restrictions] [--fees DAYS] [--temp-uploads] [--temp-uploads-days DAYS] [--uploads-missing 0|1 ] [--statistics DAYS] [--deleted-catalog DAYS] [--deleted-patrons DAYS] [--old-issues DAYS] [--old-reserves DAYS] [--transfers DAYS] [--labels DAYS] [--cards DAYS] -h --help prints this help message, and exits, ignoring all other options @@ -145,6 +145,8 @@ my $pOldReserves; my $pTransfers; my ( $pPseudoTransactions, $pPseudoTransactionsFrom, $pPseudoTransactionsTo ); my $pMessages; +my $labels; +my $cards; GetOptions( 'h|help' => \$help, @@ -180,6 +182,8 @@ GetOptions( 'pseudo-transactions:i' => \$pPseudoTransactions, 'pseudo-transactions-from:s' => \$pPseudoTransactionsFrom, 'pseudo-transactions-to:s' => \$pPseudoTransactionsTo, + 'labels' => \$labels, + 'cards' => \$cards, ) || usage(1); # Use default values @@ -225,6 +229,8 @@ unless ( $sessions || $pPseudoTransactionsFrom || $pPseudoTransactionsTo || $pMessages + || $labels + || $cards ) { print "You did not specify any cleanup work for the script to do.\n\n"; usage(1); -- 2.11.0