Bugzilla – Attachment 11813 Details for
Bug 8112
Overdues with Fines report, giving duplicates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli
0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli.patch (text/plain), 1.38 KB, created by
wajasu
on 2012-08-23 22:55:05 UTC
(
hide
)
Description:
0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli
Filename:
MIME Type:
Creator:
wajasu
Created:
2012-08-23 22:55:05 UTC
Size:
1.38 KB
patch
obsolete
>From f7d8dd7698f2860c77de67a025901af80f4002cc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 17 May 2012 10:40:30 -0400 >Subject: [PATCH 1/2] [SIGNED-OFF] Bug 8112 - Overdues with Fines giving > duplicates > >If a borrower has multiple fines of type FU for a given item, >that row will appear in the Overdues with Fines report >for each fine on record. > >Fixed by grouping the results by borrowernumber. > >Signed-off-by: wajasu <matted-34813@mypacks.net> >--- > C4/Overdues.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index d17f445..e2a8abf 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -1261,10 +1261,10 @@ sub GetOverduesForBranch { > my $i = 0; > my $sth; > if ($location) { >- $sth = $dbh->prepare("$select AND items.location = ? ORDER BY borrowers.surname, borrowers.firstname"); >+ $sth = $dbh->prepare("$select AND items.location = ? GROUP BY borrowers.borrowernumber ORDER BY borrowers.surname, borrowers.firstname"); > $sth->execute($branch, $location); > } else { >- $sth = $dbh->prepare("$select ORDER BY borrowers.surname, borrowers.firstname"); >+ $sth = $dbh->prepare("$select GROUP BY borrowers.borrowernumber ORDER BY borrowers.surname, borrowers.firstname"); > $sth->execute($branch); > } > while ( my $data = $sth->fetchrow_hashref ) { >-- >1.7.11.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8112
:
9628
|
11578
| 11813 |
11814
|
11815
|
11816
|
11817
|
11818
|
12309
|
15582