From 6d93b77e0a313cf1b9ece0853b141ca3cf9616f0 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 15 Mar 2021 14:07:26 +0000
Subject: [PATCH] Bug 27899: Missing description for libraryNotPickupLocation
 on request.pl

This patch adds text to the holds template in the staff client so that
if a particular item is at a library which isn't a hold location the
error message is descriptive.

To test, apply the patch and go to Administration -> Libraries.

 - Change one of your libraries so that "Pickup location" is set to
   "No."
 - Locate a title in the catalog which has an item at that location.
 - Start the process of placing a hold on the title.
 - After selecting a patron to place the hold for, look at the table of
   items under "PLace a hold on a specific item."
 - The item located at the library you modified should show an error
   message in the "Hold" column, "Library is not a pickup location."
---
 koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 5dfff18595..49d5e3b58c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -587,6 +587,8 @@
                                                                         Cannot be transferred to pickup library
                                                                     [% ELSIF itemloo.not_holdable == 'pickupNotInHoldGroup' %]
                                                                         Only pickup locations within the same hold group are allowed
+                                                                    [% ELSIF itemloo.not_holdable == 'libraryNotPickupLocation' %]
+                                                                        Library is not a pickup location
                                                                     [% ELSE %]
                                                                         [% itemloo.not_holdable | html %]
                                                                     [% END %]
-- 
2.11.0