From 5f931da5ee9a5330a19dc6d923c29b20ae0f7432 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 15 Mar 2021 16:02:34 +0000 Subject: [PATCH] Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 --- opac/opac-detail.pl | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index e4e4a8341d..6f21216adb 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -749,13 +749,14 @@ if ( not $viewallitems and @items > $max_items_to_display ) { my $reserve_status = C4::Reserves::GetReserveStatus($itm->{itemnumber}); if( $reserve_status eq "Waiting"){ $itm->{'waiting'} = 1; } if( $reserve_status eq "Reserved"){ $itm->{'onhold'} = 1; } - - my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($itm->{itemnumber}); - if ( defined( $transfertwhen ) && $transfertwhen ne '' ) { - $itm->{transfertwhen} = $transfertwhen; - $itm->{transfertfrom} = $transfertfrom; - $itm->{transfertto} = $transfertto; - } + + + my $transfer = $item->get_transfer; + if ( $transfer->in_transit ) { + $itm->{transfertwhen} = output_pref({ dt => dt_from_string($transfer->datesent), dateonly => 1 }); + $itm->{transfertfrom} = $transfer->frombranch; + $itm->{transfertto} = $transfer->tobranch; + } if ( C4::Context->preference('OPACAcquisitionDetails') ) { $itm->{on_order} = 1 -- 2.20.1