From 2f6fd4d84085ddcfde2a7e6ced42d6ba86be8932 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 15 Mar 2021 16:15:22 +0000
Subject: [PATCH] Bug 24295: Remove GetTransfers from reserve.pl

This patch replaces the call to GetTransfers in reserve.pl with the
get_transfer method available from the Koha::Item object

Test plan
1/ Place a reserve on an item at a different branch
2/ Trigger the transfer of the item
3/ Check the reserves page for the display of the current transfer
   status
4/ Apply patch
5/ Repeat step 3
---
 reserve/request.pl | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/reserve/request.pl b/reserve/request.pl
index 1751a0aa92..2f70b66565 100755
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -518,13 +518,11 @@ foreach my $biblionumber (@biblionumbers) {
             }
 
             # Check the transit status
-            my ( $transfertwhen, $transfertfrom, $transfertto ) =
-              GetTransfers($itemnumber);
-
-            if ( defined $transfertwhen && $transfertwhen ne '' ) {
-                $item->{transfertwhen} = output_pref({ dt => dt_from_string( $transfertwhen ), dateonly => 1 });
-                $item->{transfertfrom} = $transfertfrom;
-                $item->{transfertto} = $transfertto;
+            my $transfer = $item_object->get_transfer;
+            if ( $transfer->in_transit ) {
+                $item->{transfertwhen} = output_pref({ dt => dt_from_string($transfer->datesent), dateonly => 1 });
+                $item->{transfertfrom} = $transfer->frombranch;
+                $item->{transfertto} = $transfer->tobranch;
                 $item->{nocancel} = 1;
             }
 
-- 
2.20.1