From 305ba1dd19bd1631cb26357578a1cf26a72e047f Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 16 Mar 2021 08:56:18 +0000 Subject: [PATCH] Bug 24295: Replace GetTransfers in t/db_dependent/Circulation.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in Ciculation.t Test plan 1/ Run t/db_dependent/Circulation.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 --- t/db_dependent/Circulation.t | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index d0bfe6e207..ee371ed840 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -3426,17 +3426,17 @@ subtest 'Cancel transfers on lost items' => sub { is( $hold->found, 'T', 'Hold is in transit' ); #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost - my ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber); - is( $frombranch, $library_1->{branchcode}, 'The transfer is generated from the correct library'); - is( $tobranch, $library_2->{branchcode}, 'The transfer is generated to the correct library'); + my $transfer = $item->get_transfer; + is( $transfer->frombranch, $library_1->{branchcode}, 'The transfer is generated from the correct library'); + is( $transfer->tobranch, $library_2->{branchcode}, 'The transfer is generated to the correct library'); my $itemcheck = Koha::Items->find($item->itemnumber); is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origination branch before it is marked as lost' ); - #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch + #Simulate item being marked as lost and confirm the transfer is cancelled and the items holding branch is the transfers source branch $item->itemlost(1)->store; LostItem( $item->itemnumber, 'test', 1 ); - ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber); - is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled'); + $transfer = $item->get_transfer; + is( $transfer, undef, 'The transfer on the lost item has been cancelled as the LostItemCancelOutstandingTransfer is enabled'); $itemcheck = Koha::Items->find($item->itemnumber); is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' ); -- 2.20.1