Bugzilla – Attachment 118289 Details for
Bug 27835
Closed days offsets with one day
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27835: Add new syspref ChargeFinesOnCloseDay
Bug-27835-Add-new-syspref-ChargeFinesOnCloseDay.patch (text/plain), 4.29 KB, created by
Jonathan Druart
on 2021-03-16 09:22:42 UTC
(
hide
)
Description:
Bug 27835: Add new syspref ChargeFinesOnCloseDay
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-03-16 09:22:42 UTC
Size:
4.29 KB
patch
obsolete
>From 0af68bfbd5c292e73035999ca3ceb359fd035802 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 16 Mar 2021 10:16:51 +0100 >Subject: [PATCH] Bug 27835: Add new syspref ChargeFinesOnCloseDay > >--- > installer/data/mysql/atomicupdate/bug_27835.perl | 10 ++++++++++ > installer/data/mysql/mandatory/sysprefs.sql | 1 + > .../prog/en/modules/admin/preferences/circulation.pref | 8 +++++++- > 3 files changed, 18 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_27835.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_27835.perl b/installer/data/mysql/atomicupdate/bug_27835.perl >new file mode 100644 >index 0000000000..5f718a9ca5 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_27835.perl >@@ -0,0 +1,10 @@ >+$DBversion = 'XXX'; # will be replaced by the RM >+if( CheckVersion( $DBversion ) ) { >+ >+ $dbh->do(q| >+ INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) >+ VALUES ('ChargeFinesOnCloseDay', '1', NULL, 'Charge fines on close day.', 'YesNo') >+ |); >+ >+ NewVersion( $DBversion, 27835, "Add new system preference ChargeFinesOnCloseDay"); >+} >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 3ead03b283..f0401d61d4 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -121,6 +121,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('casServerUrl','https://localhost:8443/cas','','URL of the cas server','Free'), > ('CatalogModuleRelink','0',NULL,'If OFF the linker will never replace the authids that are set in the cataloging module.','YesNo'), > ('CataloguingLog','1',NULL,'If ON, log edit/create/delete actions on bibliographic data. WARNING: this feature is very resource consuming.','YesNo'), >+('ChargeFinesOnCloseDay','1',NULL,'Charge fines on close day.','YesNo') > ('CheckPrevCheckout','hardno','hardyes|softyes|softno|hardno','By default, for every item checked out, should we warn if the patron has borrowed that item in the past?','Choice'), > ('CheckPrevCheckoutDelay','0', NULL,'Maximum number of days that will trigger a warning if the patron has borrowed that item in the past when CheckPrevCheckout is enabled.','free'), > ('CircAutoPrintQuickSlip','qslip',NULL,'Choose what should happen when an empty barcode field is submitted in circulation: Display a print quick slip window, Display a print slip window or Clear the screen.','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 3bb28f5541..b38798fc35 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -969,7 +969,13 @@ Circulation: > off: "Don't calculate" > production: Calculate and charge > - fines (when <code>cronjobs/fines.pl</code> is being run). >- - '<br><strong>NOTE:</strong> If the cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CalculateFinesOnReturn">CalculateFinesOnReturn</a> is enabled, final fines will be calculated when an item is returned.' >+ - '<br><strong>NOTE:</strong> If the cronjobs/fines.pl cronjob is being run, accruing and final fines will be calculated when the cron runs and accruing fines will be finalized when an item is returned. If <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=CalculateFinesOnReturn">CalculateFinesOnReturn</a> is enabled, final fines will be calculated when an item is returned.<br/>' >+ - pref: ChargeFinesOnCloseDay >+ type: choice >+ choices: >+ 0: "Don't charge" >+ 1: Charge >+ - on close days. If set the fines.pl cronjob will not generate fines when run on days marked as closed in the calendar. > - > - If a lost item is returned, apply the refunding rules defined for the > - pref: RefundLostOnReturnControl >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27835
:
118032
|
118033
|
118288
|
118289
|
118290
|
118319
|
118320
|
118321
|
118322
|
118361
|
118414
|
118415
|
118416
|
118417
|
118418