From ebf64453068d7a97a643a3d1cc4a29b439cb5016 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 15 Mar 2021 16:18:36 +0000 Subject: [PATCH] Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 --- catalogue/detail.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 8049906bac..c9a613874b 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -355,11 +355,11 @@ foreach my $item (@items) { } # Check the transit status - my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($item->{itemnumber}); - if ( defined( $transfertwhen ) && ( $transfertwhen ne '' ) ) { - $item->{transfertwhen} = $transfertwhen; - $item->{transfertfrom} = $transfertfrom; - $item->{transfertto} = $transfertto; + my $transfer = $item_object->get_transfer; + if ( $transfer->in_transit ) { + $item->{transfertwhen} = output_pref({ dt => dt_from_string($transfer->datesent), dateonly => 1 }); + $item->{transfertfrom} = $transfer->frombranch; + $item->{transfertto} = $transfer->tobranch; $item->{nocancel} = 1; } -- 2.20.1