Bugzilla – Attachment 118375 Details for
Bug 20817
Add ability to retain 9xx fields when adding on order item to existing record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues
Bug-20817-Rename-getinfossyspref-to-GetMarcFieldsT.patch (text/plain), 4.69 KB, created by
Kyle M Hall
on 2021-03-17 13:46:37 UTC
(
hide
)
Description:
Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2021-03-17 13:46:37 UTC
Size:
4.69 KB
patch
obsolete
>From 8d071fa62f12b8896ddffc41438043614cd5797e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 21 May 2020 10:34:58 -0400 >Subject: [PATCH] Bug 20817: Rename get_infos_syspref to > GetMarcFieldsToOrderValues > >--- > Koha/Acquisition/Utils.pm | 8 ++++---- > acqui/addorderiso2709.pl | 2 +- > acqui/neworderempty.pl | 2 +- > t/Acquisition/Utils.t | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/Koha/Acquisition/Utils.pm b/Koha/Acquisition/Utils.pm >index 2a816b3277..74ca963276 100644 >--- a/Koha/Acquisition/Utils.pm >+++ b/Koha/Acquisition/Utils.pm >@@ -25,9 +25,9 @@ Koha::Acquisition::Utils - Additional Koha functions for dealing with orders and > > =head1 SUBROUTINES > >-=head3 get_infos_syspref($syspref_name, $record, $field_list) >+=head3 GetMarcFieldsToOrderValues($syspref_name, $record, $field_list) > >-my $data = Koha::Acquisition::Utils::get_infos_syspref('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', etc.]); >+my $data = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', etc.]); > > This subroutine accepts a syspref ( MarcFieldsToOrder ), > a marc record, and an arrayref of fields to retrieve. >@@ -38,7 +38,7 @@ given system preference. > > =cut > >-sub get_infos_syspref { >+sub GetMarcFieldsToOrderValues { > my ($syspref_name, $record, $field_list) = @_; > my $syspref = C4::Context->preference($syspref_name); > $syspref = "$syspref\n\n"; # YAML is anal on ending \n. Surplus does not hurt >@@ -76,7 +76,7 @@ The return value is a hashref of key value pairs, where the keys are the field l > and the values are extracted from the MARC record based on the key to MARC field mapping from the > given system preference. > >-The largest difference between get_infos_syspref and GetMarcItemFieldsToOrderValues is that the former deals >+The largest difference between GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues is that the former deals > with singular marc fields, while the latter works on multiple matching marc fields and returns -1 if it cannot > find a matching number of all fields to be looked up. > >diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl >index dd4e7f1e38..b353d02a65 100755 >--- a/acqui/addorderiso2709.pl >+++ b/acqui/addorderiso2709.pl >@@ -519,7 +519,7 @@ sub import_biblios_list { > my ( $marcblob, $encoding ) = GetImportRecordMarc( $biblio->{'import_record_id'} ); > my $marcrecord = MARC::Record->new_from_usmarc($marcblob) || die "couldn't translate marc information"; > >- my $infos = Koha::Acquisition::Utils::get_infos_syspref('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', 'discount', 'sort1', 'sort2','replacementprice']); >+ my $infos = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', 'discount', 'sort1', 'sort2','replacementprice']); > my $price = $infos->{price}; > my $replacementprice = $infos->{replacementprice}; > my $quantity = $infos->{quantity}; >diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl >index 2868832e8b..b46810dcdf 100755 >--- a/acqui/neworderempty.pl >+++ b/acqui/neworderempty.pl >@@ -626,7 +626,7 @@ sub staged_items_field { > my ($marcrecord, $encoding) = MARCfindbreeding($breedingid); > die("Could not find the selected record in the reservoir, bailing") unless $marcrecord; > >- my $infos = Koha::Acquisition::Utils::get_infos_syspref('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', 'discount', 'sort1', 'sort2', 'replacementprice']); >+ my $infos = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues('MarcFieldsToOrder', $marcrecord, ['price', 'quantity', 'budget_code', 'discount', 'sort1', 'sort2', 'replacementprice']); > my $price = $infos->{price}; > my $replacementprice = $infos->{replacementprice}; > my $quantity = $infos->{quantity}; >diff --git a/t/Acquisition/Utils.t b/t/Acquisition/Utils.t >index a6d2eeca1e..6cc043ce84 100755 >--- a/t/Acquisition/Utils.t >+++ b/t/Acquisition/Utils.t >@@ -33,7 +33,7 @@ $schema->storage->txn_begin; > my $builder = t::lib::TestBuilder->new; > my $dbh = C4::Context->dbh; > >-subtest "get_infos_syspref" => sub { >+subtest "GetMarcFieldsToOrderValues" => sub { > plan tests => 4; > > my $record = MARC::Record->new; >@@ -51,7 +51,7 @@ test3: 520$a > test4: 541$a > }; > t::lib::Mocks::mock_preference('MarcFieldsToOrder', $MarcFieldsToOrder); >- my $data = Koha::Acquisition::Utils::get_infos_syspref( >+ my $data = Koha::Acquisition::Utils::GetMarcFieldsToOrderValues( > 'MarcFieldsToOrder', > $record, > [ 'test1', 'test2', 'test3', 'test4' ] >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20817
:
79867
|
80537
|
86711
|
86746
|
105214
|
105215
|
105216
|
105217
|
105218
|
105219
|
115343
|
118371
|
118372
|
118373
|
118374
|
118375
|
118376
|
118377
|
118378
|
122692
|
122834
|
122841
|
122858
|
122861
|
128766
|
128767
|
128768
|
128769
|
128770
|
128771
|
128772
|
128773
|
128774
|
128775
|
128776
|
128777
|
128782
|
128783
|
128785
|
128786
|
128787
|
128788
|
128789
|
128790
|
128791
|
128792
|
128793
|
128794
|
128795
|
128796
|
128797
|
128798
|
131732
|
131733
|
131734
|
131735
|
131736
|
131737
|
131738
|
131739
|
131740
|
131741
|
131742
|
131743
|
131744
|
131745
|
131746
|
131747
|
131748
|
131749
|
142630
|
142631
|
142632
|
142633
|
142634
|
142635
|
142636
|
142637
|
142638
|
142639
|
142640
|
142641
|
142642
|
142643
|
142644
|
142645
|
142646
|
142647
|
142648
|
142649
|
142650
|
142651
|
142829