From a91f468a1b273908988d934bae8514dfb9eb9021 Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Mon, 20 Jul 2020 15:09:30 +0000 Subject: [PATCH] Bug 15563: add label and card creator batch deletion to cleanup_database To test: For item label batches: 1- Create 3 item label batches of at least 2 items each 2- Perform the following updates via the database 3- In Batch 1, set all items' timestamps to 10+ days prior to today 4- In Batch 2, set 1 item's timestamp to 10+ days prior to today 5- In Batch 3, do not update any timestamps 6- Run cron with --labels 9 7- Confirm batch 1 is deleted, batches 2 and 3 are not Repeat with card creator batches 8- Create 3 card creator batches of at least 2 items each 9- Perform the following updates via the database 10- In Batch 1, set all cards' timestamps to 10+ days prior to today 11- In Batch 2, set 1 card's timestamp to 10+ days prior to today 12- In Batch 3, do not update any timestamps 13- Run cron with --cards 9 14- Confirm batch 1 is deleted, batches 2 and 3 are noti Signed-off-by: Kelly McElligott Signed-off-by: Deb Stephenson Signed-off-by: Abbey Holt Signed-off-by: Martin Renvoize --- misc/cronjobs/cleanup_database.pl | 47 ++++++++++++++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl index 062efe6041..76f1f177d0 100755 --- a/misc/cronjobs/cleanup_database.pl +++ b/misc/cronjobs/cleanup_database.pl @@ -55,7 +55,7 @@ use Koha::Patron::Messages; sub usage { print STDERR < \$help, @@ -177,6 +182,8 @@ GetOptions( 'pseudo-transactions:i' => \$pPseudoTransactions, 'pseudo-transactions-from:s' => \$pPseudoTransactionsFrom, 'pseudo-transactions-to:s' => \$pPseudoTransactionsTo, + 'labels' => \$labels, + 'cards' => \$cards, ) || usage(1); # Use default values @@ -222,6 +229,8 @@ unless ( $sessions || $pPseudoTransactionsFrom || $pPseudoTransactionsTo || $pMessages + || $labels + || $cards ) { print "You did not specify any cleanup work for the script to do.\n\n"; usage(1); @@ -600,6 +609,42 @@ if (defined $pPseudoTransactions or $pPseudoTransactionsFrom or $pPseudoTransact } } +if ($labels) { + print "Purging item label batches last added to more than $labels days ago.\n" if $verbose; + $sth = $dbh->prepare( + q{ + DELETE from creator_batches + WHERE batch_id in + (SELECT batch_id + FROM (SELECT batch_id + FROM creator_batches + WHERE creator='labels' + GROUP BY batch_id + HAVING max(timestamp) < date_sub(curdate(),interval ? day)) a) + } + ); + $sth->execute($labels) or die $dbh->errstr; + print "Done with purging item label batches last added to more than $labels days ago.\n" if $verbose; +} + +if ($cards) { + print "Purging card creator batches last added to more than $cards days ago.\n" if $verbose; + $sth = $dbh->prepare( + q{ + DELETE from creator_batches + WHERE batch_id in + (SELECT batch_id + FROM (SELECT batch_id + FROM creator_batches + WHERE creator='patroncards' + GROUP BY batch_id + HAVING max(timestamp) < date_sub(curdate(),interval ? day)) a); + } + ); + $sth->execute($cards) or die $dbh->errstr; + print "Done with purging card creator batches last added to more than $cards days ago.\n" if $verbose; +} + exit(0); sub RemoveOldSessions { -- 2.20.1