Bugzilla – Attachment 118889 Details for
Bug 28042
Button corrections in OAI set mappings template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28042: Button corrections in OAI set mappings template
Bug-28042-Button-corrections-in-OAI-set-mappings-t.patch (text/plain), 3.76 KB, created by
Katrin Fischer
on 2021-03-27 14:02:53 UTC
(
hide
)
Description:
Bug 28042: Button corrections in OAI set mappings template
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2021-03-27 14:02:53 UTC
Size:
3.76 KB
patch
obsolete
>From 3463a460c69e9ad7cfbd9dbf1b5ace8befbe0025 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 26 Mar 2021 12:05:44 +0000 >Subject: [PATCH] Bug 28042: Button corrections in OAI set mappings template > >This patch makes minor markup changes in the OAI set mappings template >so that the "Add" button looks consistent with other buttons in the >table. > >Also changed: Removed unnecessary inline style attributes. > >To test, apply the patch and go to Administration -> OAI sets >configuration > >- If necessary, create an OAI set. >- Click the "Actions" button and choose "Define mappings." >- In the table of form fields, confirm that the "Add" button is styled > similarly to the "Delete" button. >- Confirm that the "Add" button works as expected. > >Signed-off-by: Amit Gupta <amitddng135@gmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt >index 758d4dc940..59166299cc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt >@@ -59,7 +59,7 @@ > </select> > </td> > <td><input type="text" name="marcfield" size="3" value="[% mapping.marcfield | html %]" /></td> >- <td style="text-align:center"><input type="text" name="marcsubfield" size="1" value="[% mapping.marcsubfield | html %]" /></td> >+ <td><input type="text" name="marcsubfield" size="1" value="[% mapping.marcsubfield | html %]" /></td> > <td><select name=operator> > [% IF mapping.operator == 'equal' %] > <option value="equal" selected="selected">is equal to</option> >@@ -70,9 +70,9 @@ > [% END %] > </select></td> > <td><input type="text" name="marcvalue" value="[% mapping.marcvalue | html %]" /></td> >- <td style="text-align:center"> >+ <td> > [% IF ( loop.last ) %] >- <input type="button" id="new_rule_button" value="add" title="Add another condition" /> >+ <button type="button" id="new_rule_button" class="btn btn-default btn-xs" title="Add another condition"><i class="fa fa-plus"></i> Add</button> > [% END %] > </td> > <td><button class="btn btn-default btn-xs clear-field" type="button"><i class="fa fa-trash"></i> Delete</button></td> >@@ -95,13 +95,15 @@ > </select> > </td> > <td><input type="text" name="marcfield" size="3" /></td> >- <td style="text-align:center"><input type="text" name="marcsubfield" size="1" /></td> >+ <td><input type="text" name="marcsubfield" size="1" /></td> > <td><select name=operator> > <option value="equal">is equal to</option> > <option value="notequal">not equal to</option> > </select></td> > <td><input type="text" name="marcvalue" /></td> >- <td><input type="button" id="new_rule_button" value="Add" /></td> >+ <td> >+ <button type="button" id="new_rule_button" class="btn btn-default btn-xs" title="Add another condition"><i class="fa fa-plus"></i> Add</button> >+ </td> > <td><button class="btn btn-default btn-xs clear-field" type="button"><i class="fa fa-trash"></i> Delete</button></td> > </tr> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28042
:
118855
|
118886
| 118889