From 4ce6864e142591288dbb29353ff31e7fef90ae1c Mon Sep 17 00:00:00 2001
From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Tue, 30 Mar 2021 12:13:27 +0100
Subject: [PATCH] Bug 28052 Do not check SYSENV values only keys in loop

Loop is only interested in key values, because 'keys' is omitted
it is checking values as well. This can lead to misleading errors
being logged (e.g. key is undefined)
Extract keys only to loop array as in the other loops below this
---
 C4/SIP/Sip/MsgType.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
index 62d3d5fcfc..1e38f29a68 100644
--- a/C4/SIP/Sip/MsgType.pm
+++ b/C4/SIP/Sip/MsgType.pm
@@ -333,7 +333,7 @@ sub handle {
 
     # Set system preference overrides, first global, then account level
     # Clear overrides from previous message handling first
-    foreach my $key ( %ENV ) {
+    foreach my $key ( keys %ENV ) {
         delete $ENV{$key} if index($key, 'OVERRIDE_SYSPREF_') > 0;
     }
     foreach my $key ( keys %{ $config->{'syspref_overrides'} } ) {
-- 
2.30.2