Bugzilla – Attachment 119219 Details for
Bug 25429
`cleanup_database.pl` should remove resolved claims returned after X days
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25429: Use filter_by_last_update
Bug-25429-Use-filterbylastupdate.patch (text/plain), 1.44 KB, created by
Kyle M Hall
on 2021-04-06 13:17:36 UTC
(
hide
)
Description:
Bug 25429: Use filter_by_last_update
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2021-04-06 13:17:36 UTC
Size:
1.44 KB
patch
obsolete
>From 040f3612af2aecc03f2dca2ce2623543c8072efb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 6 Apr 2021 09:16:52 -0400 >Subject: [PATCH] Bug 25429: Use filter_by_last_update > >--- > misc/cronjobs/cleanup_database.pl | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > >diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl >index 254bb7e895..00713c7485 100755 >--- a/misc/cronjobs/cleanup_database.pl >+++ b/misc/cronjobs/cleanup_database.pl >@@ -509,14 +509,22 @@ if ($pStatistics) { > > if ($return_claims) { > print "Purging return claims older than $return_claims days.\n" if $verbose; >- $sth = $dbh->prepare( >- q{ >- DELETE FROM return_claims >- WHERE resolved_on < DATE_SUB(CURDATE(), INTERVAL ? DAY) >+ >+ my $return_claims = Koha::Checkouts::ReturnClaims->filter_by_last_update( >+ { >+ timestamp_column_name => 'resolved_on', >+ days => $return_claims > } > ); >- $sth->execute($return_claims); >- print "Done with purging return claims.\n" if $verbose; >+ >+ my $count = $return_claims->count; >+ $return_claims->delete if $confirm; >+ >+ if ($verbose) { >+ say $confirm >+ ? sprintf "Done with purging %d resolved return claims.", $count >+ : sprintf "%d resolved return claims would have been purged.", $count; >+ } > } > > if ($pDeletedCatalog) { >-- >2.24.3 (Apple Git-128)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25429
:
104611
|
104612
|
104798
|
114601
|
114602
|
115042
|
115086
|
115087
|
115088
|
115089
|
115090
|
115907
|
115908
|
118880
|
118881
|
119219
|
120927
|
120928
|
120929
|
120930
|
125584
|
125585
|
125586
|
125587
|
125588