Bugzilla – Attachment 119226 Details for
Bug 28069
Can't sort lists on staff client
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28069: (bug 27715 follow-up) Fix sort for lists
Bug-28069-bug-27715-follow-up-Fix-sort-for-lists.patch (text/plain), 3.00 KB, created by
Jonathan Druart
on 2021-04-06 15:38:13 UTC
(
hide
)
Description:
Bug 28069: (bug 27715 follow-up) Fix sort for lists
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-04-06 15:38:13 UTC
Size:
3.00 KB
patch
obsolete
>From 0ca7b0940945468f0f1f17a3c8bdd70796ffe6ce Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 6 Apr 2021 17:35:33 +0200 >Subject: [PATCH] Bug 28069: (bug 27715 follow-up) Fix sort for lists > >Sort functionality has been broken by bug 27715. We need to specify the >table.column in the datatable init > >Note that "count" needs to be handled separately (which is a bit dirty >but cannot find something better) > >Test plan: >Create some lists, add contents, change owner and dates >Sort using the different attributes and confirm that it's now working >--- > C4/Utils/DataTables.pm | 7 ++++++- > .../prog/en/modules/virtualshelves/shelves.tt | 18 ++++++++++++++++++ > 2 files changed, 24 insertions(+), 1 deletion(-) > >diff --git a/C4/Utils/DataTables.pm b/C4/Utils/DataTables.pm >index 6e1af15611..ac2faad7cd 100644 >--- a/C4/Utils/DataTables.pm >+++ b/C4/Utils/DataTables.pm >@@ -104,10 +104,15 @@ sub dt_build_orderby { > > return unless @orderbys; > >+ my @sanitized_orderbys; >+ >+ # Trick for virtualshelves, should not be extended >+ push @sanitized_orderbys, 'count asc' if grep {$_ eq 'count asc'} @orderbys; >+ push @sanitized_orderbys, 'count desc' if grep {$_ eq 'count desc'} @orderbys; >+ > # Must be "branches.branchname asc", "borrowers.firstname desc", etc. > @orderbys = grep { /^\w+\.\w+ (asc|desc)$/ } @orderbys; > >- my @sanitized_orderbys; > for my $orderby (@orderbys) { > my ($identifier, $direction) = split / /, $orderby, 2; > my ($table, $column) = split /\./, $identifier, 2; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >index db6f2da101..5a006342c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt >@@ -523,6 +523,24 @@ > },{ > 'name': 'template_path', > 'value': 'virtualshelves/tables/shelves_results.tt', >+ },{ >+ 'name': 'shelfname_sorton', >+ 'value': 'vs.shelfname', >+ },{ >+ 'name': 'is_shared_sorton', >+ 'value': 'vs.category', >+ },{ >+ 'name': 'owner_sorton', >+ 'value': 'vs.owner', >+ },{ >+ 'name': 'sortby_sorton', >+ 'value': 'vs.sortfield', >+ },{ >+ 'name': 'created_on_sorton', >+ 'value': 'vs.created_on', >+ },{ >+ 'name': 'modification_time_sorton', >+ 'value': 'vs.lastmodified', > }); > $.ajax({ > 'dataType': 'json', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28069
:
119226
|
119262
|
119743