View | Details | Raw Unified | Return to bug 22690
Collapse All | Expand All

(-)a/C4/Items.pm (-52 / +1 lines)
Lines 39-45 BEGIN { Link Here
39
        GetHostItemsInfo
39
        GetHostItemsInfo
40
        get_hostitemnumbers_of
40
        get_hostitemnumbers_of
41
        GetHiddenItemnumbers
41
        GetHiddenItemnumbers
42
        MoveItemFromBiblio
43
        CartToShelf
42
        CartToShelf
44
        GetAnalyticsCount
43
        GetAnalyticsCount
45
        SearchItems
44
        SearchItems
Lines 67-72 use Koha::AuthorisedValues; Link Here
67
use Koha::DateUtils qw(dt_from_string);
66
use Koha::DateUtils qw(dt_from_string);
68
use Koha::Database;
67
use Koha::Database;
69
68
69
use Koha::Biblios;
70
use Koha::Biblioitems;
70
use Koha::Biblioitems;
71
use Koha::Items;
71
use Koha::Items;
72
use Koha::ItemTypes;
72
use Koha::ItemTypes;
Lines 1104-1160 the inner workings of C<C4::Items>. Link Here
1104
1104
1105
=cut
1105
=cut
1106
1106
1107
=head2 MoveItemFromBiblio
1108
1109
  MoveItemFromBiblio($itenumber, $frombiblio, $tobiblio);
1110
1111
Moves an item from a biblio to another
1112
1113
Returns undef if the move failed or the biblionumber of the destination record otherwise
1114
1115
=cut
1116
1117
sub MoveItemFromBiblio {
1118
    my ($itemnumber, $frombiblio, $tobiblio) = @_;
1119
    my $dbh = C4::Context->dbh;
1120
    my ( $tobiblioitem ) = $dbh->selectrow_array(q|
1121
        SELECT biblioitemnumber
1122
        FROM biblioitems
1123
        WHERE biblionumber = ?
1124
    |, undef, $tobiblio );
1125
    my $return = $dbh->do(q|
1126
        UPDATE items
1127
        SET biblioitemnumber = ?,
1128
            biblionumber = ?
1129
        WHERE itemnumber = ?
1130
            AND biblionumber = ?
1131
    |, undef, $tobiblioitem, $tobiblio, $itemnumber, $frombiblio );
1132
    if ($return == 1) {
1133
        my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
1134
        $indexer->index_records( $tobiblio, "specialUpdate", "biblioserver" );
1135
        $indexer->index_records( $frombiblio, "specialUpdate", "biblioserver" );
1136
	    # Checking if the item we want to move is in an order 
1137
        require C4::Acquisition;
1138
        my $order = C4::Acquisition::GetOrderFromItemnumber($itemnumber);
1139
	    if ($order) {
1140
		    # Replacing the biblionumber within the order if necessary
1141
		    $order->{'biblionumber'} = $tobiblio;
1142
	        C4::Acquisition::ModOrder($order);
1143
	    }
1144
1145
        # Update reserves, hold_fill_targets, tmp_holdsqueue and linktracker tables
1146
        for my $table_name ( qw( reserves hold_fill_targets tmp_holdsqueue linktracker ) ) {
1147
            $dbh->do( qq|
1148
                UPDATE $table_name
1149
                SET biblionumber = ?
1150
                WHERE itemnumber = ?
1151
            |, undef, $tobiblio, $itemnumber );
1152
        }
1153
        return $tobiblio;
1154
	}
1155
    return;
1156
}
1157
1158
=head2 _marc_from_item_hash
1107
=head2 _marc_from_item_hash
1159
1108
1160
  my $item_marc = _marc_from_item_hash($item, $frameworkcode[, $unlinked_item_subfields]);
1109
  my $item_marc = _marc_from_item_hash($item, $frameworkcode[, $unlinked_item_subfields]);
(-)a/Koha/Biblio.pm (+24 lines)
Lines 41-46 use Koha::CirculationRules; Link Here
41
use Koha::Item::Transfer::Limits;
41
use Koha::Item::Transfer::Limits;
42
use Koha::Items;
42
use Koha::Items;
43
use Koha::Libraries;
43
use Koha::Libraries;
44
use Koha::SearchEngine::Indexer;
44
use Koha::Suggestions;
45
use Koha::Suggestions;
45
use Koha::Subscriptions;
46
use Koha::Subscriptions;
46
47
Lines 887-892 sub to_api_mapping { Link Here
887
    };
888
    };
888
}
889
}
889
890
891
=head3 adopt_items_from_biblio
892
893
$biblio->adopt_items_from_biblio($from_biblio);
894
895
Move items from the given biblio to this one.
896
897
=cut
898
899
sub adopt_items_from_biblio {
900
    my ( $self, $from_biblio ) = @_;
901
902
    my $items = $from_biblio->items;
903
    if ($items) {
904
        while (my $item = $items->next()) {
905
            $item->move_to_biblio($self, { skip_record_index => 1 });
906
        }
907
        my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
908
        $indexer->index_records( $self->biblionumber, "specialUpdate", "biblioserver" );
909
        $indexer->index_records( $from_biblio->biblionumber, "specialUpdate", "biblioserver" );
910
    }
911
}
912
913
890
=head2 Internal methods
914
=head2 Internal methods
891
915
892
=head3 type
916
=head3 type
(-)a/Koha/Item.pm (+84 lines)
Lines 1143-1148 sub itemtype { Link Here
1143
    return Koha::ItemTypes->find( $self->effective_itemtype );
1143
    return Koha::ItemTypes->find( $self->effective_itemtype );
1144
}
1144
}
1145
1145
1146
=head3 item_orders
1147
1148
my $orders = $item->item_orders();
1149
1150
Returns a Koha::Acquisition::Orders object
1151
1152
=cut
1153
1154
sub item_orders {
1155
    my ( $self ) = @_;
1156
1157
    my $orders = $self->_result->item_orders;
1158
    return unless $orders;
1159
    return Koha::Acquisition::Orders->_new_from_dbic($orders);
1160
}
1161
1162
=head3 move_to_biblio
1163
1164
  $item->move_to_biblio($to_biblio[, $params]);
1165
1166
Move the item to another biblio and update any references also in other tables.
1167
1168
The final optional parameter, C<$params>, is expected to contain the
1169
'skip_record_index' key, which is relayed down to Koha::Item->store.
1170
There it prevents calling index_records, which takes most of the
1171
time in batch adds/deletes. The caller must take care of calling
1172
index_records separately.
1173
1174
$params:
1175
    skip_record_index => 1|0
1176
1177
Returns undef if the move failed or the biblionumber of the destination record otherwise
1178
1179
=cut
1180
1181
sub move_to_biblio {
1182
    my ( $self, $to_biblio, $params ) = @_;
1183
1184
    $params //= {};
1185
1186
    return unless $self->biblionumber != $to_biblio->biblionumber;
1187
1188
    my $biblionumber = $to_biblio->biblionumber;
1189
1190
    # Own biblionumber and biblioitemnumber
1191
    $self->set({
1192
        biblionumber => $biblionumber,
1193
        biblioitemnumber => $to_biblio->biblioitem->biblioitemnumber
1194
    })->store({ skip_record_index => $params->{skip_record_index} });
1195
1196
    # Acquisition orders
1197
    my $orders = $self->item_orders;
1198
    if ($orders) {
1199
        $orders->update({ biblionumber => $biblionumber }, { no_triggers => 1 });
1200
    }
1201
1202
    # Holds
1203
    $self->holds->update({ biblionumber => $biblionumber });
1204
1205
    # hold_fill_target (there's no Koha object available)
1206
    my $hold_fill_target = $self->_result->hold_fill_target;
1207
    if ($hold_fill_target) {
1208
        $hold_fill_target->update({ biblionumber => $biblionumber });
1209
    }
1210
1211
    # tmp_holdsqueues - Can't update with DBIx since the table is missing a primary key
1212
    # and can't even fake one since the significant columns are nullable.
1213
    my $storage = $self->_result->result_source->storage;
1214
    $storage->dbh_do(
1215
        sub {
1216
            my ($storage, $dbh, @cols) = @_;
1217
1218
            $dbh->do("UPDATE tmp_holdsqueue SET biblionumber=? WHERE itemnumber=?", undef, $biblionumber, $self->itemnumber);
1219
        }
1220
    );
1221
1222
    # linktrackers
1223
    my $schema = Koha::Database->new()->schema();
1224
    my $linktrackers = $schema->resultset('Linktracker')->search({ itemnumber => $self->itemnumber });
1225
    $linktrackers->update_all({ biblionumber => $biblionumber });
1226
1227
    return $biblionumber;
1228
}
1229
1146
=head2 Internal methods
1230
=head2 Internal methods
1147
1231
1148
=head3 _after_item_action_hooks
1232
=head3 _after_item_action_hooks
(-)a/Koha/Schema/Result/Item.pm (+13 lines)
Lines 866-871 __PACKAGE__->add_columns( Link Here
866
    '+exclude_from_local_holds_priority' => { is_boolean => 1 },
866
    '+exclude_from_local_holds_priority' => { is_boolean => 1 },
867
);
867
);
868
868
869
# Relationship with orders via the aqorders_item table that not have foreign keys
870
__PACKAGE__->has_many(
871
  "aqorders_item",
872
  "Koha::Schema::Result::AqordersItem",
873
  { "foreign.itemnumber" => "self.itemnumber" },
874
  { cascade_copy => 0, cascade_delete => 0 },
875
);
876
__PACKAGE__->many_to_many(
877
  "item_orders",
878
  "aqorders_item",
879
  "ordernumber",
880
);
881
869
use C4::Context;
882
use C4::Context;
870
sub effective_itemtype {
883
sub effective_itemtype {
871
    my ( $self ) = @_;
884
    my ( $self ) = @_;
(-)a/cataloguing/merge.pl (-15 / +7 lines)
Lines 31-36 use C4::Reserves qw/MergeHolds/; Link Here
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
31
use C4::Acquisition qw/ModOrder GetOrdersByBiblionumber/;
32
32
33
use Koha::BiblioFrameworks;
33
use Koha::BiblioFrameworks;
34
use Koha::Biblios;
34
use Koha::Items;
35
use Koha::Items;
35
use Koha::MetadataRecord;
36
use Koha::MetadataRecord;
36
37
Lines 80-104 if ($merge) { Link Here
80
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
81
    $record->leader(GetMarcBiblio({ biblionumber => $ref_biblionumber })->leader());
81
82
82
    my $frameworkcode = $input->param('frameworkcode');
83
    my $frameworkcode = $input->param('frameworkcode');
83
    my @notmoveditems;
84
84
85
    # Modifying the reference record
85
    # Modifying the reference record
86
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
86
    ModBiblio($record, $ref_biblionumber, $frameworkcode);
87
87
88
    # Moving items from the other record to the reference record
88
    # Moving items and article requests from the other record to the reference record
89
    my $biblio = Koha::Biblios->find($ref_biblionumber);
89
    foreach my $biblionumber (@biblionumbers) {
90
    foreach my $biblionumber (@biblionumbers) {
90
        my $items = Koha::Items->search({ biblionumber => $biblionumber });
91
        my $from_biblio = Koha::Biblios->find($biblionumber);
91
        while ( my $item = $items->next) {
92
        $biblio->adopt_items_from_biblio($from_biblio);
92
            my $res = MoveItemFromBiblio( $item->itemnumber, $biblionumber, $ref_biblionumber );
93
        $from_biblio->article_requests->update({ biblionumber => $ref_biblionumber }, { no_triggers => 1 });
93
            if ( not defined $res ) {
94
                push @notmoveditems, $item->itemnumber;
95
            }
96
        }
97
    }
98
    # If some items could not be moved :
99
    if (scalar(@notmoveditems) > 0) {
100
        my $itemlist = join(' ',@notmoveditems);
101
        push @errors, { code => "CANNOT_MOVE", value => $itemlist };
102
    }
94
    }
103
95
104
    my $sth_subscription = $dbh->prepare("
96
    my $sth_subscription = $dbh->prepare("
Lines 162-168 if ($merge) { Link Here
162
    # Moving suggestions
154
    # Moving suggestions
163
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
155
    $sth_suggestions->execute($ref_biblionumber, $biblionumber);
164
156
165
    # Moving orders (orders linked to items of frombiblio have already been moved by MoveItemFromBiblio)
157
    # Moving orders (orders linked to items of frombiblio have already been moved by adopt_items_from_biblio)
166
    my @allorders = GetOrdersByBiblionumber($biblionumber);
158
    my @allorders = GetOrdersByBiblionumber($biblionumber);
167
    foreach my $myorder (@allorders) {
159
    foreach my $myorder (@allorders) {
168
        $myorder->{'biblionumber'} = $ref_biblionumber;
160
        $myorder->{'biblionumber'} = $ref_biblionumber;
(-)a/cataloguing/moveitem.pl (-1 / +2 lines)
Lines 73-80 if ( $barcode && $biblionumber ) { Link Here
73
73
74
        $itemnumber = $item->itemnumber;
74
        $itemnumber = $item->itemnumber;
75
        my $frombiblionumber = $item->biblionumber;
75
        my $frombiblionumber = $item->biblionumber;
76
        my $to_biblio = Koha::Biblios->find($biblionumber);
76
77
77
        my $moveresult = MoveItemFromBiblio( $itemnumber, $frombiblionumber, $biblionumber );
78
        my $moveresult = $item->move_to_biblio($to_biblio);
78
        if ($moveresult) {
79
        if ($moveresult) {
79
            $template->param(
80
            $template->param(
80
                success => 1,
81
                success => 1,
(-)a/t/db_dependent/Items/MoveItemFromBiblio.t (-85 lines)
Lines 1-85 Link Here
1
#!/usr/bin/perl
2
#
3
# This file is part of Koha.
4
#
5
# Koha is free software; you can redistribute it and/or modify it
6
# under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 3 of the License, or
8
# (at your option) any later version.
9
#
10
# Koha is distributed in the hope that it will be useful, but
11
# WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
18
use Modern::Perl;
19
use Test::More tests => 8;
20
21
use C4::Items;
22
use C4::Reserves;
23
use Koha::Database;
24
use Koha::Holds;
25
use Koha::Items;
26
27
use t::lib::TestBuilder;
28
use Data::Dumper qw|Dumper|;
29
30
my $schema  = Koha::Database->new->schema;
31
$schema->storage->txn_begin;
32
my $builder = t::lib::TestBuilder->new;
33
34
my $from_biblio = $builder->build_sample_biblio;
35
my $to_biblio = $builder->build_sample_biblio;
36
37
my $item1 = $builder->build_sample_item(
38
    { biblionumber => $from_biblio->biblionumber, } );
39
my $item2 = $builder->build_sample_item(
40
    { biblionumber => $from_biblio->biblionumber, } );
41
my $item3 = $builder->build_sample_item(
42
    { biblionumber => $to_biblio->biblionumber, } );
43
44
45
my $bib_level_hold_not_to_move = $builder->build(
46
    {   source => 'Reserve',
47
        value  => { biblionumber => $from_biblio->biblionumber, },
48
    }
49
);
50
my $item_level_hold_not_to_move = $builder->build(
51
    {   source => 'Reserve',
52
        value  => { biblionumber => $from_biblio->biblionumber, itemnumber => $item1->itemnumber },
53
    }
54
);
55
my $item_level_hold_to_move = $builder->build(
56
    {   source => 'Reserve',
57
        value  => { biblionumber => $from_biblio->biblionumber, itemnumber => $item2->itemnumber },
58
    }
59
);
60
61
my $to_biblionumber_after_moved = C4::Items::MoveItemFromBiblio( $item2->itemnumber, $from_biblio->biblionumber, $to_biblio->biblionumber );
62
63
is( $to_biblionumber_after_moved, $to_biblio->biblionumber, 'MoveItemFromBiblio should return the to_biblionumber if success' );
64
65
$to_biblionumber_after_moved = C4::Items::MoveItemFromBiblio( $item2->itemnumber, $from_biblio->biblionumber, $to_biblio->biblionumber );
66
67
is( $to_biblionumber_after_moved, undef, 'MoveItemFromBiblio should return undef if the move has failed. If called twice, the item is not attached to the first biblio anymore' );
68
69
my $get_item1 = Koha::Items->find( $item1->itemnumber );
70
is( $get_item1->biblionumber, $from_biblio->biblionumber, 'The item1 should not have been moved' );
71
my $get_item2 = Koha::Items->find( $item2->itemnumber );
72
is( $get_item2->biblionumber, $to_biblio->biblionumber, 'The item2 should have been moved' );
73
my $get_item3 = Koha::Items->find( $item3->itemnumber );
74
is( $get_item3->biblionumber, $to_biblio->biblionumber, 'The item3 should not have been moved' );
75
76
my $get_bib_level_hold    = Koha::Holds->find( $bib_level_hold_not_to_move->{reserve_id} );
77
my $get_item_level_hold_1 = Koha::Holds->find( $item_level_hold_not_to_move->{reserve_id} );
78
my $get_item_level_hold_2 = Koha::Holds->find( $item_level_hold_to_move->{reserve_id} );
79
80
is( $get_bib_level_hold->biblionumber,    $from_biblio->biblionumber, 'MoveItemFromBiblio should not have moved the biblio-level hold' );
81
is( $get_item_level_hold_1->biblionumber, $from_biblio->biblionumber, 'MoveItemFromBiblio should not have moved the item-level hold placed on item 1' );
82
is( $get_item_level_hold_2->biblionumber, $to_biblio->biblionumber,   'MoveItemFromBiblio should have moved the item-level hold placed on item 2' );
83
84
$schema->storage->txn_rollback;
85
(-)a/t/db_dependent/Koha/Item.t (-1 / +180 lines)
Lines 19-25 Link Here
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
21
22
use Test::More tests => 8;
22
use Test::More tests => 10;
23
use Test::Exception;
23
use Test::Exception;
24
24
25
use C4::Biblio;
25
use C4::Biblio;
Lines 696-698 subtest 'Tests for itemtype' => sub { Link Here
696
696
697
    $schema->storage->txn_rollback;
697
    $schema->storage->txn_rollback;
698
};
698
};
699
700
subtest 'move_to_biblio() tests' => sub {
701
702
    plan tests => 16;
703
704
    $schema->storage->txn_begin;
705
706
    my $dbh = C4::Context->dbh;
707
708
    my $source_biblio = $builder->build_sample_biblio();
709
    my $target_biblio = $builder->build_sample_biblio();
710
711
    my $source_biblionumber = $source_biblio->biblionumber;
712
    my $target_biblionumber = $target_biblio->biblionumber;
713
714
    my $item1 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
715
    my $item2 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
716
    my $item3 = $builder->build_sample_item({ biblionumber => $source_biblionumber });
717
718
    my $itemnumber1 = $item1->itemnumber;
719
    my $itemnumber2 = $item2->itemnumber;
720
721
    my $library = $builder->build_object({ class => 'Koha::Libraries' });
722
723
    my $patron = $builder->build_object({
724
        class => 'Koha::Patrons',
725
        value => { branchcode => $library->branchcode }
726
    });
727
    my $borrowernumber = $patron->borrowernumber;
728
729
    my $aq_budget = $builder->build({
730
        source => 'Aqbudget',
731
        value  => {
732
            budget_notes => 'test',
733
        },
734
    });
735
736
    my $aq_order1 = $builder->build_object({
737
        class => 'Koha::Acquisition::Orders',
738
        value  => {
739
            biblionumber => $source_biblionumber,
740
            budget_id => $aq_budget->{budget_id},
741
        },
742
    });
743
    my $aq_order_item1 = $builder->build({
744
        source => 'AqordersItem',
745
        value  => {
746
            ordernumber => $aq_order1->ordernumber,
747
            itemnumber => $itemnumber1,
748
        },
749
    });
750
    my $aq_order2 = $builder->build_object({
751
        class => 'Koha::Acquisition::Orders',
752
        value  => {
753
            biblionumber => $source_biblionumber,
754
            budget_id => $aq_budget->{budget_id},
755
        },
756
    });
757
    my $aq_order_item2 = $builder->build({
758
        source => 'AqordersItem',
759
        value  => {
760
            ordernumber => $aq_order2->ordernumber,
761
            itemnumber => $itemnumber2,
762
        },
763
    });
764
765
    my $bib_level_hold = $builder->build_object({
766
        class => 'Koha::Holds',
767
        value  => {
768
            biblionumber => $source_biblionumber,
769
        },
770
    });
771
    my $item_level_hold1 = $builder->build_object({
772
        class => 'Koha::Holds',
773
        value  => {
774
            biblionumber => $source_biblionumber,
775
            itemnumber => $itemnumber1,
776
        },
777
    });
778
    my $item_level_hold2 = $builder->build_object({
779
        class => 'Koha::Holds',
780
        value  => {
781
            biblionumber => $source_biblionumber,
782
            itemnumber => $itemnumber2,
783
        }
784
    });
785
786
    my $tmp_holdsqueue1 = $builder->build({
787
        source => 'TmpHoldsqueue',
788
        value  => {
789
            borrowernumber => $borrowernumber,
790
            biblionumber   => $source_biblionumber,
791
            itemnumber     => $itemnumber1,
792
        }
793
    });
794
    my $tmp_holdsqueue2 = $builder->build({
795
        source => 'TmpHoldsqueue',
796
        value  => {
797
            borrowernumber => $borrowernumber,
798
            biblionumber   => $source_biblionumber,
799
            itemnumber     => $itemnumber2,
800
        }
801
    });
802
    my $hold_fill_target1 = $builder->build({
803
        source => 'HoldFillTarget',
804
        value  => {
805
            borrowernumber     => $borrowernumber,
806
            biblionumber       => $source_biblionumber,
807
            itemnumber         => $itemnumber1,
808
        }
809
    });
810
    my $hold_fill_target2 = $builder->build({
811
        source => 'HoldFillTarget',
812
        value  => {
813
            borrowernumber     => $borrowernumber,
814
            biblionumber       => $source_biblionumber,
815
            itemnumber         => $itemnumber2,
816
        }
817
    });
818
    my $linktracker1 = $builder->build({
819
        source => 'Linktracker',
820
        value  => {
821
            borrowernumber     => $borrowernumber,
822
            biblionumber       => $source_biblionumber,
823
            itemnumber         => $itemnumber1,
824
        }
825
    });
826
    my $linktracker2 = $builder->build({
827
        source => 'Linktracker',
828
        value  => {
829
            borrowernumber     => $borrowernumber,
830
            biblionumber       => $source_biblionumber,
831
            itemnumber         => $itemnumber2,
832
        }
833
    });
834
835
    my $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
836
    is($to_biblionumber_after_move, $target_biblionumber, 'move_to_biblio returns the target biblionumber if success');
837
838
    $to_biblionumber_after_move = $item1->move_to_biblio($target_biblio);
839
    is($to_biblionumber_after_move, undef, 'move_to_biblio returns undef if the move has failed. If called twice, the item is not attached to the first biblio anymore');
840
841
    my $get_item1 = Koha::Items->find( $item1->itemnumber );
842
    is($get_item1->biblionumber, $target_biblionumber, 'item1 is moved');
843
    my $get_item2 = Koha::Items->find( $item2->itemnumber );
844
    is($get_item2->biblionumber, $source_biblionumber, 'item2 is not moved');
845
    my $get_item3 = Koha::Items->find( $item3->itemnumber );
846
    is($get_item3->biblionumber, $source_biblionumber, 'item3 is not moved');
847
848
    $aq_order1->discard_changes;
849
    $aq_order2->discard_changes;
850
    is($aq_order1->biblionumber, $target_biblionumber, 'move_to_biblio moves aq_orders for item 1');
851
    is($aq_order2->biblionumber, $source_biblionumber, 'move_to_biblio does not move aq_orders for item 2');
852
853
    $bib_level_hold->discard_changes;
854
    $item_level_hold1->discard_changes;
855
    $item_level_hold2->discard_changes;
856
    is($bib_level_hold->biblionumber,   $source_biblionumber, 'move_to_biblio does not move the biblio-level hold');
857
    is($item_level_hold1->biblionumber, $target_biblionumber, 'move_to_biblio moves the item-level hold placed on item 1');
858
    is($item_level_hold2->biblionumber, $source_biblionumber, 'move_to_biblio does not move the item-level hold placed on item 2');
859
860
    my $get_tmp_holdsqueue1 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue1->{itemnumber} })->single;
861
    my $get_tmp_holdsqueue2 = $schema->resultset('TmpHoldsqueue')->search({ itemnumber => $tmp_holdsqueue2->{itemnumber} })->single;
862
    is($get_tmp_holdsqueue1->biblionumber, $target_biblionumber, 'move_to_biblio moves tmp_holdsqueue for item 1');
863
    is($get_tmp_holdsqueue2->biblionumber, $source_biblionumber, 'move_to_biblio does not move tmp_holdsqueue for item 2');
864
865
    my $get_hold_fill_target1 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target1->{itemnumber} })->single;
866
    my $get_hold_fill_target2 = $schema->resultset('HoldFillTarget')->search({ itemnumber => $hold_fill_target2->{itemnumber} })->single;
867
    # Why does ->biblionumber return a Biblio object???
868
    is($get_hold_fill_target1->biblionumber->biblionumber, $target_biblionumber, 'move_to_biblio moves hold_fill_targets for item 1');
869
    is($get_hold_fill_target2->biblionumber->biblionumber, $source_biblionumber, 'move_to_biblio does not move hold_fill_targets for item 2');
870
871
    my $get_linktracker1 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker1->{itemnumber} })->single;
872
    my $get_linktracker2 = $schema->resultset('Linktracker')->search({ itemnumber => $linktracker2->{itemnumber} })->single;
873
    is($get_linktracker1->biblionumber, $target_biblionumber, 'move_to_biblio moves linktracker for item 1');
874
    is($get_linktracker2->biblionumber, $source_biblionumber, 'move_to_biblio does not move linktracker for item 2');
875
876
    $schema->storage->txn_rollback;
877
};
(-)a/t/db_dependent/Koha/SearchEngine/Indexer.t (-2 / +10 lines)
Lines 61-67 subtest 'Test indexer object creation' => sub { Link Here
61
};
61
};
62
62
63
subtest 'Test indexer calls' => sub {
63
subtest 'Test indexer calls' => sub {
64
    plan tests => 40;
64
    plan tests => 44;
65
65
66
    my @engines = ('Zebra');
66
    my @engines = ('Zebra');
67
    eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; };
67
    eval { Koha::SearchEngine::Elasticsearch->get_elasticsearch_params; };
Lines 159-164 subtest 'Test indexer calls' => sub { Link Here
159
            AddReturn($item->barcode, $item->homebranch, 0, undef);
159
            AddReturn($item->barcode, $item->homebranch, 0, undef);
160
        } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued";
160
        } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued";
161
161
162
        my $item3 = $builder->build_sample_item({biblionumber => $biblio->biblionumber});
163
        my $item4 = $builder->build_sample_item({biblionumber => $biblio->biblionumber});
164
        warnings_are{
165
            $item3->move_to_biblio($biblio2);
166
        } [$engine,"Koha::Item"], "index_records is called for $engine when moving an item to another biblio (Item->move_to_biblio)";
167
        warnings_are{
168
            $item4->move_to_biblio($biblio2, { skip_record_index => 1 });
169
        } undef, "index_records is not called for $engine when moving an item to another biblio (Item->move_to_biblio) if skip_record_index passed";
170
162
        $builder->build(
171
        $builder->build(
163
            {
172
            {
164
                source => 'Branchtransfer',
173
                source => 'Branchtransfer',
165
- 

Return to bug 22690