Bugzilla – Attachment 119528 Details for
Bug 28140
Accessibility: OPAC - "sort_by" select isn't labelled on search results page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page
Bug-28140-Accessibility-OPAC---sortby-select-isnt-.patch (text/plain), 1.69 KB, created by
Henry Bolshaw
on 2021-04-13 11:18:08 UTC
(
hide
)
Description:
Bug 28140: Accessibility: OPAC - "sort_by" select isn't labelled on search results page
Filename:
MIME Type:
Creator:
Henry Bolshaw
Created:
2021-04-13 11:18:08 UTC
Size:
1.69 KB
patch
obsolete
>From 3f4b02dba536cb9191448c4b3b341031a70a6aaa Mon Sep 17 00:00:00 2001 >From: Henry Bolshaw <bolshawh@parliament.uk> >Date: Tue, 13 Apr 2021 10:49:09 +0000 >Subject: [PATCH] Bug 28140: Accessibility: OPAC - "sort_by" select isn't > labelled on search results page > >This patch adds a label to the sort function on the OPAC >results page to provide context to screen readers and improve >accessibility. > >The label is visually hidden and does not change how the page >displays. > >To test: >- Search for something on the OPAC >- Change how the results are sorted and confirm sort still works >- Confirm that there are no visual changes to the page >- Inspect the sort function to confirm it now has a label >- Ideally confirm the label works with a screenreader >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index ad6c7eed7d..2fe0ecd021 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -180,6 +180,7 @@ > </div> > [% UNLESS tag %] > <div class="sort_by col-sm-auto"> >+ <label for="sort_by" class="sr-only">Sort by:</label> > <select id="sort_by" class="resort form-control form-control-sm" name="sort_by"> > [% INCLUDE 'resort_form.inc' %] > </select> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28140
:
119528
|
119556
|
119750