View | Details | Raw Unified | Return to bug 28125
Collapse All | Expand All

(-)a/about.pl (+5 lines)
Lines 201-206 my $warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist = ( not $anonymous_pat Link Here
201
201
202
my $warnPrefKohaAdminEmailAddress = not Email::Valid->address(C4::Context->preference('KohaAdminEmailAddress'));
202
my $warnPrefKohaAdminEmailAddress = not Email::Valid->address(C4::Context->preference('KohaAdminEmailAddress'));
203
203
204
my $c = Koha::Items->filter_by_visible_in_opac->count;
205
my @warnings = C4::Context->dbh->selectrow_array('SHOW WARNINGS');
206
my $warnPrefOpacHiddenItems = $warnings[2];
207
204
my $invalid_yesno = Koha::Config::SysPrefs->search(
208
my $invalid_yesno = Koha::Config::SysPrefs->search(
205
    {
209
    {
206
        type  => 'YesNo',
210
        type  => 'YesNo',
Lines 601-606 $template->param( Link Here
601
    warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist     => $warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist,
605
    warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist     => $warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist,
602
    warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist => $warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist,
606
    warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist => $warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist,
603
    warnPrefKohaAdminEmailAddress => $warnPrefKohaAdminEmailAddress,
607
    warnPrefKohaAdminEmailAddress => $warnPrefKohaAdminEmailAddress,
608
    warnPrefOpacHiddenItems => $warnPrefOpacHiddenItems,
604
    errZebraConnection => $errZebraConnection,
609
    errZebraConnection => $errZebraConnection,
605
    warnIsRootUser => $warnIsRootUser,
610
    warnIsRootUser => $warnIsRootUser,
606
    warnNoActiveCurrency => $warnNoActiveCurrency,
611
    warnNoActiveCurrency => $warnNoActiveCurrency,
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt (-2 / +5 lines)
Lines 215-221 Link Here
215
        </div>
215
        </div>
216
216
217
        <div id="sysinfo">
217
        <div id="sysinfo">
218
    [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker %]
218
    [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker %]
219
        [% IF (warnIsRootUser) %]
219
        [% IF (warnIsRootUser) %]
220
            <h2>Warning regarding current user</h2>
220
            <h2>Warning regarding current user</h2>
221
            <p>You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
221
            <p>You are logged in as the database administrative user. This is not recommended because some parts of Koha will not function as expected when using this account.</p>
Lines 299-305 Link Here
299
            Contact your system administrator.
299
            Contact your system administrator.
300
        [% END %]
300
        [% END %]
301
301
302
        [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || paypal_enabled %]
302
        [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || invalid_yesno.count || warnNoActiveCurrency || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || oauth2_missing_deps || bad_yaml_prefs || warnIssuingRules || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || paypal_enabled %]
303
            <h2>Warnings regarding the system configuration</h2>
303
            <h2>Warnings regarding the system configuration</h2>
304
            <table>
304
            <table>
305
                <caption>Preferences and parameters</caption>
305
                <caption>Preferences and parameters</caption>
Lines 324-329 Link Here
324
                [% IF warnPrefKohaAdminEmailAddress %]
324
                [% IF warnPrefKohaAdminEmailAddress %]
325
                    <tr><th scope="row"><strong>Warning</strong> </th><td>System preference 'KohaAdminEmailAddress' does not contain a valid email address. Emails will not be sent.</td></tr>
325
                    <tr><th scope="row"><strong>Warning</strong> </th><td>System preference 'KohaAdminEmailAddress' does not contain a valid email address. Emails will not be sent.</td></tr>
326
                [% END %]
326
                [% END %]
327
                [% IF warnPrefOpacHiddenItems %]
328
                    <tr><th scope="row"><strong>Warning</strong> </th><td>System preference 'OpacHiddenItems' generates a warning and will produce unexpected behaviors: [% warnPrefOpacHiddenItems %]</th></tr>
329
                [% END %]
327
                [% IF invalid_yesno.count %]
330
                [% IF invalid_yesno.count %]
328
                    [% FOR p IN invalid_yesno %]
331
                    [% FOR p IN invalid_yesno %]
329
                        <tr><th scope="row"><strong>Warning</strong> </th><td>System preference '[% p.variable | html %]' must be '0' or '1', but is [% IF p.value.defined %]'[% p.value | html%]'[% ELSE %]NULL[% END %].</td></tr>
332
                        <tr><th scope="row"><strong>Warning</strong> </th><td>System preference '[% p.variable | html %]' must be '0' or '1', but is [% IF p.value.defined %]'[% p.value | html%]'[% ELSE %]NULL[% END %].</td></tr>
(-)a/t/db_dependent/Koha/Items.t (-2 / +7 lines)
Lines 1494-1500 $schema->storage->txn_rollback; Link Here
1494
1494
1495
subtest 'filter_by_visible_in_opac() tests' => sub {
1495
subtest 'filter_by_visible_in_opac() tests' => sub {
1496
1496
1497
    plan tests => 11;
1497
    plan tests => 12;
1498
1498
1499
    $schema->storage->txn_begin;
1499
    $schema->storage->txn_begin;
1500
1500
Lines 1641-1646 subtest 'filter_by_visible_in_opac() tests' => sub { Link Here
1641
        'The right item is returned'
1641
        'The right item is returned'
1642
    );
1642
    );
1643
1643
1644
    # Make sure the warning on the about page will work
1645
    $rules = { itemlost => ['AB'] };
1646
    my $c = Koha::Items->filter_by_visible_in_opac->count;
1647
    my @warnings = C4::Context->dbh->selectrow_array('SHOW WARNINGS');
1648
    is( $warnings[2], q{Truncated incorrect DOUBLE value: 'AB'});
1649
1644
    $schema->storage->txn_rollback;
1650
    $schema->storage->txn_rollback;
1645
};
1651
};
1646
1652
1647
- 

Return to bug 28125