From addefa1b955cfa631eba31df7cdc00af1165ceb8 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Mon, 12 Apr 2021 16:01:03 -0300 Subject: [PATCH] Bug 28118: Default to current branch when placing hold During bug 27071 development, this line got inadvertedly changed. This patch restores the original behaviour. To test: 1. Search for a title 2. Go try place a hold => FAIL: Look at the HTML, there's no pickup location with selected="selected" 3. Switch branch and repeat 2 => FAIL: Still the same 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Branch is selected, chosen current branch is picked 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Henry Bolshaw --- reserve/request.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reserve/request.pl b/reserve/request.pl index dffe1da436..a1f115a8ba 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -67,7 +67,7 @@ my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user( ); my $showallitems = $input->param('showallitems'); -my $pickup = $input->param('pickup'); +my $pickup = $input->param('pickup') // C4::Context->userenv->{branch}; my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; @@ -551,7 +551,7 @@ foreach my $biblionumber (@biblionumbers) { $item->{'holdallowed'} = $branchitemrule->{'holdallowed'}; - my $reserves_control_branch = $pickup // C4::Reserves::GetReservesControlBranch( $item, $patron_unblessed ); + my $reserves_control_branch = C4::Reserves::GetReservesControlBranch( $item, $patron_unblessed ); my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $reserves_control_branch )->{status}; $item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' ); -- 2.11.0