Bugzilla – Attachment 119613 Details for
Bug 26312
Add some error handling during Elasticsearch indexing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26312: (follow-up) Reset buffers even if commit fails
Bug-26312-follow-up-Reset-buffers-even-if-commit-f.patch (text/plain), 1.47 KB, created by
Joonas Kylmälä
on 2021-04-15 11:30:35 UTC
(
hide
)
Description:
Bug 26312: (follow-up) Reset buffers even if commit fails
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-04-15 11:30:35 UTC
Size:
1.47 KB
patch
obsolete
>From 9164f17ea6b8c8d14fb6e98ce45b27ae58072579 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 7 Dec 2020 11:33:03 +0000 >Subject: [PATCH] Bug 26312: (follow-up) Reset buffers even if commit fails >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > misc/search_tools/rebuild_elasticsearch.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/misc/search_tools/rebuild_elasticsearch.pl b/misc/search_tools/rebuild_elasticsearch.pl >index e88b1e9201..9206b4c11a 100755 >--- a/misc/search_tools/rebuild_elasticsearch.pl >+++ b/misc/search_tools/rebuild_elasticsearch.pl >@@ -307,9 +307,6 @@ sub _do_reindex { > try{ > $response = $indexer->update_index( \@id_buffer, \@commit_buffer ); > _handle_response($response); >- $commit_count = $commit; >- @id_buffer = (); >- @commit_buffer = (); > _log( 1, "Commit complete\n" ); > } catch { > if( ref $_ eq 'Koha::Exceptions::Elasticsearch::BadResponse'){ >@@ -317,6 +314,9 @@ sub _do_reindex { > _log(2,$_->{details}); > } > } >+ $commit_count = $commit; >+ @id_buffer = (); >+ @commit_buffer = (); > } > } > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26312
:
109241
|
109626
|
113501
|
114229
|
117618
|
117619
|
119014
|
119079
|
119612
|
119613
|
119614
|
119615
|
119699
|
119700