Bugzilla – Attachment 119685 Details for
Bug 28123
Commas in file names of uploaded files cause inconsistently broken 856$u links
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28123: Fix expected value in unit test
Bug-28123-Fix-expected-value-in-unit-test.patch (text/plain), 1.25 KB, created by
Nick Clemens
on 2021-04-15 19:27:02 UTC
(
hide
)
Description:
Bug 28123: Fix expected value in unit test
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2021-04-15 19:27:02 UTC
Size:
1.25 KB
patch
obsolete
>From bd745083f21fb406dfa342cae38cd49a4d71b208 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Tue, 13 Apr 2021 00:45:42 +0000 >Subject: [PATCH] Bug 28123: Fix expected value in unit test > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Upload.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/Upload.t b/t/db_dependent/Upload.t >index 23a50caa01..9d535dd2be 100755 >--- a/t/db_dependent/Upload.t >+++ b/t/db_dependent/Upload.t >@@ -323,7 +323,7 @@ subtest 'Testing download headers' => sub { > plan tests => 2; > my $test_pdf = Koha::UploadedFile->new({ filename => 'pdf.pdf', uploadcategorycode => 'B', filesize => 1000 }); > my $test_not = Koha::UploadedFile->new({ filename => 'pdf.not', uploadcategorycode => 'B', filesize => 1000 }); >- my @pdf_expect = ( '-type'=>'application/pdf','Content-Disposition'=>'inline; filename=pdf.pdf' ); >+ my @pdf_expect = ( '-type'=>'application/pdf','Content-Disposition'=>'inline; filename="pdf.pdf"' ); > my @not_expect = ( '-type'=>'application/octet-stream','-attachment'=>'pdf.not' ); > my @pdf_head = $test_pdf->httpheaders; > my @not_head = $test_not->httpheaders; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28123
:
119494
|
119495
|
119610
|
119611
|
119684
| 119685