View | Details | Raw Unified | Return to bug 24295
Collapse All | Expand All

(-)a/C4/Circulation.pm (-30 lines)
Lines 117-123 BEGIN { Link Here
117
	# subs to deal with transfers
117
	# subs to deal with transfers
118
	push @EXPORT, qw(
118
	push @EXPORT, qw(
119
		&transferbook
119
		&transferbook
120
		&GetTransfers
121
		&GetTransfersFromTo
120
		&GetTransfersFromTo
122
		&updateWrongTransfer
121
		&updateWrongTransfer
123
                &IsBranchTransferAllowed
122
                &IsBranchTransferAllowed
Lines 3426-3460 sub AddIssuingCharge { Link Here
3426
    );
3425
    );
3427
}
3426
}
3428
3427
3429
=head2 GetTransfers
3430
3431
  GetTransfers($itemnumber);
3432
3433
=cut
3434
3435
sub GetTransfers {
3436
    my ($itemnumber) = @_;
3437
3438
    my $dbh = C4::Context->dbh;
3439
3440
    my $query = '
3441
        SELECT datesent,
3442
               frombranch,
3443
               tobranch,
3444
               branchtransfer_id,
3445
               daterequested,
3446
               reason
3447
        FROM branchtransfers
3448
        WHERE itemnumber = ?
3449
          AND datearrived IS NULL
3450
          AND datecancelled IS NULL
3451
        ';
3452
    my $sth = $dbh->prepare($query);
3453
    $sth->execute($itemnumber);
3454
    my @row = $sth->fetchrow_array();
3455
    return @row;
3456
}
3457
3458
=head2 GetTransfersFromTo
3428
=head2 GetTransfersFromTo
3459
3429
3460
  @results = GetTransfersFromTo($frombranch,$tobranch);
3430
  @results = GetTransfersFromTo($frombranch,$tobranch);
(-)a/t/db_dependent/Circulation/transfers.t (-17 / +1 lines)
Lines 27-33 use Koha::Item::Transfers; Link Here
27
27
28
use t::lib::TestBuilder;
28
use t::lib::TestBuilder;
29
29
30
use Test::More tests => 22;
30
use Test::More tests => 19;
31
use Test::Deep;
31
use Test::Deep;
32
32
33
BEGIN {
33
BEGIN {
Lines 38-44 can_ok( Link Here
38
    qw(
38
    qw(
39
      CreateBranchTransferLimit
39
      CreateBranchTransferLimit
40
      DeleteBranchTransferLimits
40
      DeleteBranchTransferLimits
41
      GetTransfers
42
      GetTransfersFromTo
41
      GetTransfersFromTo
43
      )
42
      )
44
);
43
);
Lines 168-187 is(CreateBranchTransferLimit(undef,$branchcode_2),undef, Link Here
168
#branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys
167
#branch_transfer_limits.toBranch and branch_transfer_limits.fromBranch aren't foreign keys
169
#is(CreateBranchTransferLimit(-1,-1,'CODE'),0,"With wrong CreateBranchTransferLimit returns 0 - No transfertlimit added");
168
#is(CreateBranchTransferLimit(-1,-1,'CODE'),0,"With wrong CreateBranchTransferLimit returns 0 - No transfertlimit added");
170
169
171
#Test GetTransfers
172
my @transfers = GetTransfers($item_id1);
173
cmp_deeply(
174
    \@transfers,
175
    [ re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), $branchcode_1, $branchcode_2, re('[0-9]*'), re('^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$'), 'Manual' ],
176
    "Transfers of the item1"
177
);    #NOTE: Only the first transfer is returned
178
@transfers = GetTransfers;
179
is_deeply( \@transfers, [],
180
    "GetTransfers without params returns an empty array" );
181
@transfers = GetTransfers(-1);
182
is_deeply( \@transfers, [],
183
    "GetTransfers with a wrong item id returns an empty array" );
184
185
#Test GetTransfersFromTo
170
#Test GetTransfersFromTo
186
my @transferfrom1to2 = GetTransfersFromTo( $branchcode_1,
171
my @transferfrom1to2 = GetTransfersFromTo( $branchcode_1,
187
    $branchcode_2 );
172
    $branchcode_2 );
188
- 

Return to bug 24295