From ba5dde4a04d951b7a4b51387b35738dec2fcffe0 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 21 Apr 2021 16:17:25 -0300 Subject: [PATCH] Bug 23207: (QA follow-up) Add COMMENT to new column Signed-off-by: Tomas Cohen Arazi JD amended patch: FIX syntax error.(swap COMMENT and AFTER) --- installer/data/mysql/atomicupdate/bug_23027.perl | 7 ++++--- installer/data/mysql/kohastructure.sql | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_23027.perl b/installer/data/mysql/atomicupdate/bug_23027.perl index 5e7a57894c..4494ae6850 100644 --- a/installer/data/mysql/atomicupdate/bug_23027.perl +++ b/installer/data/mysql/atomicupdate/bug_23027.perl @@ -1,9 +1,10 @@ $DBversion = 'XXX'; # will be replaced by the RM if( CheckVersion( $DBversion ) ) { if( !column_exists( 'itemtypes', 'automatic_checkin' ) ) { - $dbh->do(q{ - ALTER TABLE itemtypes ADD COLUMN `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 AFTER `searchcategory` -- 1 if automatic checkin is enabled for items of this type - }); + $dbh->do(q{ + ALTER TABLE itemtypes + ADD COLUMN `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'If automatic checkin is enabled for items of this type' AFTER `searchcategory` + }); } # Always end with this (adjust the bug info) diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index 06e16e0591..18fe28cd8e 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -3133,7 +3133,7 @@ CREATE TABLE `itemtypes` ( `sip_media_type` varchar(3) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'SIP2 protocol media type for this itemtype', `hideinopac` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'Hide the item type from the search options in OPAC', `searchcategory` varchar(80) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'Group this item type with others with the same value on OPAC search options', - `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0, -- 1 if automatic checkin is enabled for items of this type + `automatic_checkin` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'If automatic checkin is enabled for items of this type', PRIMARY KEY (`itemtype`), UNIQUE KEY `itemtype` (`itemtype`), KEY `itemtypes_ibfk_1` (`parent_type`), -- 2.20.1