From 7e4cb6a8f674266fb83f85b4d93f969a2913c006 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 22 Apr 2021 09:35:11 +0100 Subject: [PATCH] Bug 27281: (QA follow-up) Restore test for holdingbranch I inadvertantly removed the test that varified that the items holdingbranch is unaffected by the call to LostItem. This restores such a test and adds a few comments to clarify the test transfers. --- t/db_dependent/Circulation.t | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 143c5c8a79..f95002efa0 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -3475,16 +3475,18 @@ subtest 'Set waiting flag' => sub { }; subtest 'Cancel transfers on lost items' => sub { - plan tests => 5; + plan tests => 6; my $library_to = $builder->build_object( { class => 'Koha::Libraries' } ); my $item = $builder->build_sample_item(); + my $holdingbranch = $item->holdingbranch; + # Historic transfer (datearrived is defined) my $old_transfer = $builder->build_object( { class => 'Koha::Item::Transfers', value => { itemnumber => $item->itemnumber, - frombranch => $item->holdingbranch, + frombranch => $holdingbranch, tobranch => $library_to->branchcode, reason => 'Manual', datesent => \'NOW()', @@ -3494,12 +3496,13 @@ subtest 'Cancel transfers on lost items' => sub { } } ); + # Queued transfer (datesent is undefined) my $transfer_1 = $builder->build_object( { class => 'Koha::Item::Transfers', value => { itemnumber => $item->itemnumber, - frombranch => $item->holdingbranch, + frombranch => $holdingbranch, tobranch => $library_to->branchcode, reason => 'Manual', datesent => undef, @@ -3509,12 +3512,13 @@ subtest 'Cancel transfers on lost items' => sub { } } ); + # In transit transfer (datesent is defined, datearrived and datecancelled are both undefined) my $transfer_2 = $builder->build_object( { class => 'Koha::Item::Transfers', value => { itemnumber => $item->itemnumber, - frombranch => $item->holdingbranch, + frombranch => $holdingbranch, tobranch => $library_to->branchcode, reason => 'Manual', datesent => \'NOW()', @@ -3537,6 +3541,8 @@ subtest 'Cancel transfers on lost items' => sub { is($transfer_2->cancellation_reason, 'ItemLost', "Cancellation reason was set to 'ItemLost'"); $old_transfer->discard_changes; is($old_transfer->datecancelled, undef, "Old transfers are unaffected"); + $item->discard_changes; + is($item->holdingbranch, $holdingbranch, "Items holding branch remains unchanged"); }; subtest 'CanBookBeIssued | is_overdue' => sub { -- 2.20.1