From 514f6a274ef72f82dd02498135cdb6ff09050780 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Wed, 21 Apr 2021 14:45:14 +0300 Subject: [PATCH] Bug 28168: leave the field empty if amount variable is empty Add "if" check to the template so that it uses the value of "debit_type.default_amount" only if it's true, i.e. not null or 0. The reason for this patch is there's requirement from librarians - to have this field completely empty if it's 0, so they could paste the amount (as they usually do) without the need to clear the field first. And anyway if you try to save the form with 0.00 value, it won't accept it saying "Debit amount passed is not positive" so in my opinion there's no point to preset it with zeroes to begin with. To reproduce: 1) head to /cgi-bin/koha/members/maninvoice.pl?borrowernumber=XXXX and check that field "Amount" is prefilled with 0.00; 2) apply patch; 3) refresh page and ensure that field "Amount" is empty now; 4) go to /cgi-bin/koha/admin/debit_types.pl and change default amount to some decimal amount; 5) refresh manual invoice page again and ensure that "Amount" field is prefilled with that exact decimal number; Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt index 5e9e7a18bb..7849d763b8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt @@ -108,7 +108,7 @@