From 56e5353ccdefdbb64d418143656c1b373a1d6515 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Mon, 26 Apr 2021 06:30:17 -0400 Subject: [PATCH] Bug 28221 - Script process_message_queue.pl uses Try::Tiny but doesn't 'use' it The message queue processor has a try/catch block, but does not have a 'use Try::Tiny' line. Because of this the following error ocurrs if an instance has any plugins installed that use the before_send_messages hook: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /usr/share/koha/bin/cronjobs/process_message_queue.pl line 86. Test Plan: 1) Install a plugin that uses the before_send_messages hook 2) Run the message queue processor 3) Note the error message 4) Apply this patch 5) Run the message queue processor again 6) No error! --- misc/cronjobs/process_message_queue.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl index 664936753f..a903f1e06d 100755 --- a/misc/cronjobs/process_message_queue.pl +++ b/misc/cronjobs/process_message_queue.pl @@ -30,6 +30,7 @@ use Koha::Script -cron; use C4::Letters; use C4::Log; use Getopt::Long; +use Try::Tiny; my $username = undef; my $password = undef; -- 2.24.3 (Apple Git-128)