Bugzilla – Attachment 120213 Details for
Bug 23406
When using an authorised value for suppression, record doesn't show as suppressed in staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23406: Test for 1 or 'Yes' in record suppression
Bug-23406-Test-for-1-or-Yes-in-record-suppression.patch (text/plain), 2.09 KB, created by
Nick Clemens
on 2021-04-27 12:30:48 UTC
(
hide
)
Description:
Bug 23406: Test for 1 or 'Yes' in record suppression
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2021-04-27 12:30:48 UTC
Size:
2.09 KB
patch
obsolete
>From 5d32ddb84f7ab21a96cccff9a0fe963286099e6d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 27 Apr 2021 12:25:12 +0000 >Subject: [PATCH] Bug 23406: Test for 1 or 'Yes' in record suppression > >In marc21 we now link the 942$n to 'YES_NO' authorised values. When displaying >the details page in the staff client the authorised values in a record are >translated before parsing the record with XSLT > >The '1' for YES_NO is translated to 'Yes' - we simply need to test for this additional >value in the XSLT to ensure we display the suppression message > >To test: > 1 - Confirm 952$n in default framework is tied ot authorised value 'YES_NO' or do so > 2 - Set OpacSuppression to 'Hide' > 3 - Edit a record in the default template, changing 942$n to 'Yes' > 4 - Confirm the record is suppressed in opac > 5 - Note there is no suppression notice in the record in staff client > 6 - Apply patch > 7 - Reload and confirm staff side shows suppression notice > 8 - Confirm record still suppressed in OPAC > 9 - Edit record, set 942$n to 'no' >10 - Confirm there is no suppression notice in staff client >11 - Confirm you can view the record in OPAC >--- > koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index 079f44a14a..f2e83a023e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -99,7 +99,8 @@ > > <!-- Indicate if record is suppressed in OPAC --> > <xsl:if test="$OpacSuppression = 1"> >- <xsl:if test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']"> >+ <xsl:variable name="suppressed" select="marc:datafield[@tag=942]/marc:subfield[@code='n']"/> >+ <xsl:if test="$suppressed='1' or $suppressed='Yes'"> > <span class="results_summary suppressed_opac">Suppressed in OPAC</span> > </xsl:if> > </xsl:if> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23406
:
120213
|
120719
|
120772
|
120773
|
120803
|
120804
|
120807
|
120808