Bugzilla – Attachment 120249 Details for
Bug 27203
Order unitprice is not set anymore and totals are 0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27203: (Bug 23294 follow up) set unitprice to ecost if it's 0.
Bug-27203-Bug-23294-follow-up-set-unitprice-to-eco.patch (text/plain), 1.32 KB, created by
Victor Grousset/tuxayo
on 2021-04-28 01:56:00 UTC
(
hide
)
Description:
Bug 27203: (Bug 23294 follow up) set unitprice to ecost if it's 0.
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2021-04-28 01:56:00 UTC
Size:
1.32 KB
patch
obsolete
>From 42147b0621df02dcc755b80b4199d9e46ca9980c Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Thu, 3 Dec 2020 09:15:15 +0100 >Subject: [PATCH] Bug 27203: (Bug 23294 follow up) set unitprice to ecost if > it's 0. > >Test plan: >1 - Create a basket >2 - Add an order line, don't set 'Actual cost: ', but use vendor price >and a discount. >3 - Save >4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. >5 - Apply batch >6 - Redo 1,2, 3 >7 - Display all columns, pre 23294 behaviour is back columns are set. > >Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > acqui/addorder.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/addorder.pl b/acqui/addorder.pl >index 417c57d261..a42bf0432f 100755 >--- a/acqui/addorder.pl >+++ b/acqui/addorder.pl >@@ -283,7 +283,7 @@ if ( $basket->{is_standing} || $orderinfo->{quantity} ne '0' ) { > ); > } > >- $orderinfo->{unitprice} = $orderinfo->{ecost} if not defined $orderinfo->{unitprice} or $orderinfo->{unitprice} eq ''; >+ $orderinfo->{unitprice} = $orderinfo->{ecost} if not defined $orderinfo->{unitprice} or $orderinfo->{unitprice} eq '' or $orderinfo->{unitprice} == 0; > > $orderinfo = C4::Acquisition::populate_order_with_prices( > { >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27203
:
114342
|
114476
|
120051
|
120052
|
120053
|
120249
|
120250
|
120551
|
120552
|
120724
|
120725
|
120765
|
120814
|
120815