Bugzilla – Attachment 120327 Details for
Bug 28207
Crash when seeing MARC structure of a new framework
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP BY
Bug-28207-Fix-biblioframeworkframeworktext-isnt-in.patch (text/plain), 3.22 KB, created by
Julian Maurice
on 2021-04-30 08:25:34 UTC
(
hide
)
Description:
Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP BY
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2021-04-30 08:25:34 UTC
Size:
3.22 KB
patch
obsolete
>From fe108b1e7603ece9de5e82bb4575e23b954ccb66 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 26 Apr 2021 10:49:12 +0200 >Subject: [PATCH] Bug 28207: Fix biblio_framework.frameworktext isn't in GROUP > BY > >When a new framework is created and "Marc structure" is opened, a SQL >error happened if sql_strict_mode is on. > >Test plan: >Create a 2 new biblio frameworks >Click "Marc structure" for one of them >=> You see the list of all frameworks with an existing structure > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > admin/marctagstructure.pl | 22 +++++++++---------- > .../prog/en/modules/admin/marctagstructure.tt | 4 ++-- > 2 files changed, 12 insertions(+), 14 deletions(-) > >diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl >index cc47c60440..634ea5e985 100755 >--- a/admin/marctagstructure.pl >+++ b/admin/marctagstructure.pl >@@ -187,18 +187,16 @@ if ($op eq 'add_form') { > ################## ITEMTYPE_CREATE ################################## > # called automatically if an unexisting frameworkis selected > } elsif ($op eq 'framework_create') { >- $sth = $dbh->prepare("select count(*),marc_tag_structure.frameworkcode,frameworktext from marc_tag_structure,biblio_framework where biblio_framework.frameworkcode=marc_tag_structure.frameworkcode group by marc_tag_structure.frameworkcode"); >- $sth->execute; >- my @existingframeworkloop; >- while (my ($tot,$thisframeworkcode,$frameworktext) = $sth->fetchrow) { >- if ($tot>0) { >- push @existingframeworkloop, { >- value => $thisframeworkcode, >- frameworktext => $frameworktext, >- }; >- } >- } >- $template->param( existingframeworkloop => \@existingframeworkloop ); >+ my $frameworks = Koha::BiblioFrameworks->search( >+ { >+ 'marc_tag_structure.frameworkcode' => { '!=' => undef } >+ }, >+ { >+ join => 'marc_tag_structure', >+ distinct => 1 >+ } >+ ); >+ $template->param( existing_frameworks => $frameworks ); > > ################## DEFAULT ################################## > } else { # DEFAULT >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >index 28983854d1..88b58d9446 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt >@@ -217,8 +217,8 @@ MARC frameworks › Administration › Koha > Create framework for [% framework.frameworkcode | html %] ([% framework.frameworktext | html %]) using > <select name="existingframeworkcode"> > <option value="">Default</option> >- [% FOREACH existingframeworkloo IN existingframeworkloop %] >- <option value="[% existingframeworkloo.value | html %]">[% existingframeworkloo.frameworktext | html %]</option> >+ [% FOREACH fw IN existing_frameworks%] >+ <option value="[% fw.frameworkcode | html %]">[% fw.frameworktext | html %]</option> > [% END %] > </select> > <input type="submit" value="OK" /> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28207
:
120167
|
120185
|
120186
| 120327