Bugzilla – Attachment 120471 Details for
Bug 28288
XISBN.t is failing is 500 is returned by the webservice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28288: Prevent XSISBN.t to fail if service is returning 500
Bug-28288-Prevent-XSISBNt-to-fail-if-service-is-re.patch (text/plain), 1.47 KB, created by
Jonathan Druart
on 2021-05-04 14:39:21 UTC
(
hide
)
Description:
Bug 28288: Prevent XSISBN.t to fail if service is returning 500
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-05-04 14:39:21 UTC
Size:
1.47 KB
patch
obsolete
>From 85ea0375d90076d797a79bad405387e5a58fc2d5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 4 May 2021 16:38:27 +0200 >Subject: [PATCH] Bug 28288: Prevent XSISBN.t to fail if service is returning > 500 > >16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout >16:00:45 koha_1 | WARNING: URL Request Failed 500 read timeout >16:00:45 koha_1 | WARNING: URL Request Failed 500 Can't connect to www.librarything.com:443 >16:00:45 koha_1 | # Looks like you planned 6 tests but ran 5. >16:00:45 koha_1 | [13:59:51] t/db_dependent/XISBN.t >16:00:45 koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) >16:00:45 koha_1 | Failed 1/6 subtests >16:00:45 koha_1 | (less 3 skipped subtests: 2 okay) >--- > t/db_dependent/XISBN.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/XISBN.t b/t/db_dependent/XISBN.t >index a9825e942fc..ed34e5aa4d5 100755 >--- a/t/db_dependent/XISBN.t >+++ b/t/db_dependent/XISBN.t >@@ -60,7 +60,7 @@ t::lib::Mocks::mock_preference( 'ThingISBN', 1 ); > my $results_thingisbn; > eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1, $biblionumber4); }; > SKIP: { >- skip "Problem retrieving ThingISBN", 1 >+ skip "Problem retrieving ThingISBN", 2 > unless $@ eq ''; > ok( (any { $_->{'biblionumber'} eq $biblionumber1 } @$results_thingisbn), > "Gets correct biblionumber from a book with a similar isbn using ThingISBN." ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28288
: 120471