Bugzilla – Attachment 12052 Details for
Bug 8585
Add System Preference to specify Holds to Pull List Start Date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date
Bug-8585--Add-System-Preference-to-specify-Holds-t.patch (text/plain), 4.84 KB, created by
Kyle M Hall
on 2012-09-07 15:22:26 UTC
(
hide
)
Description:
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-09-07 15:22:26 UTC
Size:
4.84 KB
patch
obsolete
>From 3e0cd2f7970f439ee14452b7bd61cdc58335d976 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Fri, 10 Aug 2012 12:31:30 +1000 >Subject: [PATCH] Bug 8585 : Add System Preference to specify Holds to Pull List Start Date >Content-Type: text/plain; charset="utf-8" > >Currently, Koha creates a default value of 2 days ago (-2) for the start date of the Holds to pull List. This system preference allows users to specify their own default start date for this list, since users might not want to have to manually change the date all the time when they already know the set date period they want to view. > >The system preference value is specified as a positive integer, which is then passed as a negative integer in the handler script. This saves users from having to include a qualifer to the sys pref value. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > circ/pendingreserves.pl | 5 +++-- > installer/data/mysql/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 7 +++++++ > .../en/modules/admin/preferences/circulation.pref | 5 +++++ > 4 files changed, 16 insertions(+), 2 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 61bace9..a9c317d 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -68,8 +68,9 @@ my ( $year, $month, $day ) = Today(); > my $todaysdate = sprintf("%-04.4d-%-02.2d-%02.2d", $year, $month, $day); > my $yesterdaysdate = sprintf("%-04.4d-%-02.2d-%02.2d", Add_Delta_YMD($year, $month, $day, 0, 0, -1)); > # changed from delivered range of 10 years-yesterday to 2 days ago-today >-# Find two days ago for the default shelf pull start and end dates >-my $pastdate = sprintf("%-04.4d-%-02.2d-%02.2d", Add_Delta_YMD($year, $month, $day, 0, 0, -2)); >+# Find two days ago for the default shelf pull start and end dates, unless HoldsToPullStartDate sys pref is set. >+my $defaultstartdate = ( C4::Context->preference('HoldsToPullStartDate') ) ? "-".C4::Context->preference('HoldsToPullStartDate') : -2; >+my $pastdate = sprintf("%-04.4d-%-02.2d-%02.2d", Add_Delta_YMD($year, $month, $day, 0, 0, $defaultstartdate)); > > # Predefine the start and end dates if they are not already defined > $startdate =~ s/^\s+//; >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 35f92cc..9b70a40 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -371,3 +371,4 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES(' > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('SubfieldsToUseWhenPrefill','','Define a list of subfields to use when prefilling items (separated by space)','','Free'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionMarker','','Markers for age restriction indication, e.g. FSK|PEGI|Age|',NULL,'free'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('AgeRestrictionOverride',0,'Allow staff to check out an item with age restriction.',NULL,'YesNo'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('HoldsToPullStartDate','2','Set the default start date for the Holds to pull list to this many days ago',NULL,'Integer'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 25cd367..82f0bfe 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -5696,6 +5696,13 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > SetVersion($DBversion); > } > >+$DBversion = "XXX"; >+if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { >+ $dbh->do("INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('HoldsToPullStartDate','2','Set the default start date for the Holds to pull list to this many days ago',NULL,'Integer')"); >+ print "Upgrade to $DBversion done (Added HoldsToPullStartDate syspref)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index a9ed6f7..94c58b1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -52,6 +52,11 @@ Circulation: > no: "Don't allow" > - staff to specify a due date for a checkout. > - >+ - Set the default start date for the Holds to pull list to >+ - pref: HoldsToPullStartDate >+ class: integer >+ - ago. >+ - > - pref: AllowAllMessageDeletion > choices: > yes: Allow >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8585
:
11516
|
12052
|
12659
|
12796
|
12825