Bugzilla – Attachment 120606 Details for
Bug 28293
Wrong key used in Patrons::Import->generate_patron_attributes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes
Bug-28293-bug-20443-follow-up-Fix-wrong-key-in-Pat.patch (text/plain), 1.19 KB, created by
Jonathan Druart
on 2021-05-06 10:47:08 UTC
(
hide
)
Description:
Bug 28293: (bug 20443 follow-up) Fix wrong key in Patrons::Import->generate_patron_attributes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-05-06 10:47:08 UTC
Size:
1.19 KB
patch
obsolete
>From 07c6d4bbb1b8a1ee6176aaa8769b5f37af2563bd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 May 2021 11:18:55 +0200 >Subject: [PATCH] Bug 28293: (bug 20443 follow-up) Fix wrong key in > Patrons::Import->generate_patron_attributes > >It generates warnings >Use of uninitialized value in string comparison (cmp) at /kohadevbox/koha/Koha/Patrons/Import.pm line 550, <$fh> line 2. > >And does not sort correctly (no fallback on the attribute's value for repeatable attributes) >--- > Koha/Patrons/Import.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Patrons/Import.pm b/Koha/Patrons/Import.pm >index d951bf54edc..c0269106eb2 100644 >--- a/Koha/Patrons/Import.pm >+++ b/Koha/Patrons/Import.pm >@@ -538,7 +538,7 @@ sub generate_patron_attributes { > my $ok = $csv->parse($string); # parse field again to get subfields! > my @list = $csv->fields(); > my @patron_attributes = >- sort { $a->{code} cmp $b->{code} || $a->{value} cmp $b->{value} } >+ sort { $a->{code} cmp $b->{code} || $a->{attribute} cmp $b->{attribute} } > map { > my @arr = split /:/, $_, 2; > { code => $arr[0], attribute => $arr[1] } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28293
:
120606
|
120823