From 6adc0dfb9b9be1f89b711550e73d29b3db042384 Mon Sep 17 00:00:00 2001 From: Julian Maurice Date: Fri, 7 May 2021 17:57:58 +0200 Subject: [PATCH] Bug 28302: Forbid CGI::Compile 0.24 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit ยป Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. Test plan: 1. Reproduce the bug 2. Install CGI::Compile 0.25 and restart starman 3. Make sure the bug is gone :) --- cpanfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpanfile b/cpanfile index 287187f4da..2ef039431b 100644 --- a/cpanfile +++ b/cpanfile @@ -7,7 +7,7 @@ requires 'Business::ISSN', '0.91'; requires 'Bytes::Random::Secure', '0.28'; requires 'CGI', '3.15'; requires 'CGI::Carp', '1.29'; -requires 'CGI::Compile', '0.17'; +requires 'CGI::Compile', '>= 0.17, != 0.24'; requires 'CGI::Emulate::PSGI', '0.20'; requires 'CGI::Session', '4.2'; requires 'CGI::Session::Serialize::yaml', '4.2'; -- 2.20.1