From a61426b6272bc024f730968e65ad2de860229274 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 10 May 2021 14:21:46 +0100 Subject: [PATCH] Bug 28108: (QA follow-up) Move 'ORDER' back into 'ACQUITISIONS' With the re-introduction of 'AQUISITIONS' as a logging module in Koha, it makes sence to move the ORDER notice logging back into that module whilst leaving the other 'CLAIMS' notices under their own logging module code. --- C4/Letters.pm | 3 ++- installer/data/mysql/atomicupdate/claimslog.perl | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Letters.pm b/C4/Letters.pm index 03342f0428..9144f1b2ad 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -534,8 +534,9 @@ sub SendAlerts { return { error => $error } unless $success; + my $module = $action eq 'ACQUISITION ORDER' ? 'ACQUISITION' : 'CLAIMS'; logaction( - "CLAIMS", + $module, $action, undef, "To=" diff --git a/installer/data/mysql/atomicupdate/claimslog.perl b/installer/data/mysql/atomicupdate/claimslog.perl index 8045b7d147..037339cbaf 100644 --- a/installer/data/mysql/atomicupdate/claimslog.perl +++ b/installer/data/mysql/atomicupdate/claimslog.perl @@ -2,7 +2,7 @@ $DBversion = 'XXX'; # will be replaced by the RM if ( CheckVersion($DBversion) ) { $dbh->do(q{ UPDATE action_logs SET module = 'CLAIMS' - WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION ORDER' OR action = 'ACQUISITION CLAIM') + WHERE module = 'ACQUISITIONS' AND ( action = 'SERIAL CLAIM' OR action = 'ACQUISITION CLAIM') }); $dbh->do(q{ -- 2.20.1