From e36feb993f0ebb7747f49d263fd564dc129cf45c Mon Sep 17 00:00:00 2001 From: Blou Date: Mon, 10 May 2021 11:42:48 -0400 Subject: [PATCH] Bug 28310: request.pl using biblioitemnumber in biblionumber field In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold) is passing the biblioitemnumber as a value to a specified biblionumber. >> ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) All you need is a Koha instance where the values of biblionumber and biblioitemnumber are not synchronized for this to break. And break badly. --- reserve/request.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/request.pl b/reserve/request.pl index 9c83b617cf..e21838d85c 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -456,7 +456,7 @@ foreach my $biblionumber (@biblionumbers) { # (before this loop was inside that sub loop so it was O(n^2) ) my $items_any_available; - $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) + $items_any_available = ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblionumber, patron => $patron }) if $patron; foreach my $itemnumber ( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} } ) { -- 2.17.1