Bugzilla – Attachment 120801 Details for
Bug 28272
Definition files are missing additionalProperties: false
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28272: Fix note_seen, desk_id, cancellation_reason
Bug-28272-Fix-noteseen-deskid-cancellationreason.patch (text/plain), 2.53 KB, created by
Jonathan Druart
on 2021-05-10 15:55:49 UTC
(
hide
)
Description:
Bug 28272: Fix note_seen, desk_id, cancellation_reason
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-05-10 15:55:49 UTC
Size:
2.53 KB
patch
obsolete
>From 5973ced26fce9ae9c82376cacf65635d0acbe839 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 10 May 2021 17:55:30 +0200 >Subject: [PATCH] Bug 28272: Fix note_seen, desk_id, cancellation_reason > >--- > Koha/Checkout.pm | 1 + > Koha/Old/Checkout.pm | 1 + > api/v1/swagger/definitions/checkout.json | 4 ++++ > api/v1/swagger/definitions/hold.json | 8 ++++++++ > 4 files changed, 14 insertions(+) > >diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm >index 04e339136d0..3693beeb90e 100644 >--- a/Koha/Checkout.pm >+++ b/Koha/Checkout.pm >@@ -140,6 +140,7 @@ sub to_api_mapping { > lastreneweddate => 'last_renewed_date', > issuedate => 'checkout_date', > notedate => 'note_date', >+ noteseen => 'note_seen', > }; > } > >diff --git a/Koha/Old/Checkout.pm b/Koha/Old/Checkout.pm >index e0eb1e0382e..3cfc30aa6ff 100644 >--- a/Koha/Old/Checkout.pm >+++ b/Koha/Old/Checkout.pm >@@ -107,6 +107,7 @@ sub to_api_mapping { > lastreneweddate => 'last_renewed_date', > issuedate => 'checkout_date', > notedate => 'note_date', >+ noteseen => 'note_seen', > }; > } > >diff --git a/api/v1/swagger/definitions/checkout.json b/api/v1/swagger/definitions/checkout.json >index 8540ea737ac..42bdf96e1a1 100644 >--- a/api/v1/swagger/definitions/checkout.json >+++ b/api/v1/swagger/definitions/checkout.json >@@ -73,6 +73,10 @@ > "format": "date", > "description": "Datetime of the issue note" > }, >+ "note_seen": { >+ "type": ["boolean", "null"], >+ "description": "has the note been seen already" >+ }, > "issuer": { > "type": [ > "object", >diff --git a/api/v1/swagger/definitions/hold.json b/api/v1/swagger/definitions/hold.json >index 58f32343c88..2fe5b6de963 100644 >--- a/api/v1/swagger/definitions/hold.json >+++ b/api/v1/swagger/definitions/hold.json >@@ -22,11 +22,19 @@ > "type": ["string", "null"], > "description": "Internal library identifier for the pickup library" > }, >+ "desk_id": { >+ "type": ["integer", "null"], >+ "description": "The id of the desk" >+ }, > "cancellation_date": { > "type": ["string", "null"], > "format": "date", > "description": "The date the hold was cancelled" > }, >+ "cancellation_reason": { >+ "type": ["string", "null"], >+ "description": "The reason the hold was cancelled" >+ }, > "notes": { > "type": ["string", "null"], > "description": "Notes related to this hold" >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28272
:
120630
|
120673
|
120690
| 120801 |
120812
|
120819
|
120833
|
121182
|
121184