From 950114e24c2a327cbf3297ca448a8454f869beff Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 17 May 2021 17:14:16 +0100 Subject: [PATCH] Bug 28294: Convert updateWrongTransfer to use request_transfer This patch is an interim patch to prove that the updated request_transfer method achieves the same as updateWrongTransfer. Test plan 1/ Run t/db_dependant/Circulation.t before and after applying this patch. --- C4/Circulation.pm | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index c42277d3b5..c56934c800 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3591,19 +3591,17 @@ This function validate the line of brachtransfer but with the wrong destination sub updateWrongTransfer { my ( $itemNumber,$waitingAtLibrary,$FromLibrary ) = @_; - # first step: cancel the original transfer - my $item = Koha::Items->find($itemNumber); - my $transfer = $item->get_transfer; - $transfer->set({ datecancelled => dt_from_string, cancellation_reason => 'WrongTransfer' })->store(); + my $to_library = Koha::Libraries->find($waitingAtLibrary); - # second step: create a new transfer to the right location + # Request a new transfer, replacing the existing one. + my $item = Koha::Items->find($itemNumber); my $new_transfer = $item->request_transfer( { - to => $transfer->to_library, - reason => $transfer->reason, - comment => $transfer->comments, + to => $to_library, + reason => 'WrongTransfer', ignore_limits => 1, - enqueue => 1 + replace => 1, + force => 1 } ); -- 2.20.1