From 7e0965eb48a04c3ef08e568c83148845a73913b5 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 19 May 2021 16:43:47 +0100 Subject: [PATCH] Bug 28272: (QA follow-up) Add 'manager' to cashups definition The embeddable 'manager' relation field was missing from the specification file and as such calls using this embed would result in a 500 error since we introduced 'additionalProperties: false'. Test plan 1/ Enable 'UseCashRegisters' 2/ Navigate to the register details page 3/ Inspect the network traffic and note a 500 error on the cashups api call 4/ Apply the patch 5/ The 500 should have gone away and been replaced with an empty resultset 200 page. --- api/v1/swagger/definitions/cashup.json | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/api/v1/swagger/definitions/cashup.json b/api/v1/swagger/definitions/cashup.json index a4c5a42644..a2681d7632 100644 --- a/api/v1/swagger/definitions/cashup.json +++ b/api/v1/swagger/definitions/cashup.json @@ -13,6 +13,13 @@ "type": "integer", "description": "Internal identifier for the manager the cashup was performed by" }, + "manager": { + "type": [ + "object", + "null" + ], + "description": "The object representing the manager the cashup was performed by" + }, "amount": { "type": "number", "description": "Account line amount" -- 2.20.1