From 999180b084b9268956abf77fe6872d998d7ec6c6 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 19 May 2021 16:14:43 +0000 Subject: [PATCH] Bug 28394: Improve style of patron category entry form This patch makes some style and structure changes to the patron cartegory entry form: - Margin added to the enrollment period fieldset so that it aligns with the rest of the form. - Informational text inside the form wrapped in
like it is on other pages. - Converted heading tag to legend tag in the messaging preferences fieldset. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Go to Administration -> Patron categories -> New category and confirm that the style updates look good. --- .../intranet-tmpl/prog/css/src/staff-global.scss | 16 +++++++++++++++ .../prog/en/modules/admin/categories.tt | 24 +++++++++++----------- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 6d9db96973..09e3725dc7 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -866,6 +866,22 @@ fieldset { margin-left: 0; padding-left: 0; } + + fieldset { + margin-left: 10em; + + label { + width: 6em; + } + + li.radio { + padding-left: 0; + } + } + + legend { + margin-bottom: 0; + } } ol { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt index 768d1259fb..1e3f8dfe6c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt @@ -148,7 +148,7 @@ Choose one
  1. - + [% IF category.enrolmentperiod %] months [% ELSE %] @@ -156,7 +156,7 @@ [% END %]
  2. - +
@@ -220,8 +220,8 @@ [% PROCESS options_for_libraries libraries => Branches.all( selected => category.get_library_limits, unfiltered => 1, do_not_select_my_library => 1 ) %] - Select All libraries if this category type must to be displayed all the time. Otherwise select libraries you want to associate with this value. - +
Select All libraries if this category type must to be displayed all the time. Otherwise select libraries you want to associate with this value. +
  • @@ -290,7 +290,7 @@
  • - Leave blank to use system default ([% Koha.Preference('minPasswordLength') | html %]) +
    Leave blank to use system default ([% Koha.Preference('minPasswordLength') | html %])
  • @@ -344,9 +344,9 @@ [% END %] - +
    Choose whether patrons of this category be blocked from public catalog actions such as renewing and placing holds when their cards have expired. - +
  • [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' ) %]
  • @@ -365,9 +365,9 @@ [% END %] - +
    Choose whether patrons of this category by default are reminded if they try to borrow an item they borrowed before. - +
  • [% END %]
  • @@ -390,7 +390,7 @@ [% END %] - Controls how long a patrons checkout history is kept for new patrons of this category. "Never" anonymizes checkouts on return, and "Forever" keeps a patron's checkout history indefinitely. When set to "Default", the amount of history kept is controlled by the cronjob batch_anonymise.pl which should be set up by your system administrator. +
    Controls how long a patrons checkout history is kept for new patrons of this category. "Never" anonymizes checkouts on return, and "Forever" keeps a patron's checkout history indefinitely. When set to "Default", the amount of history kept is controlled by the cronjob batch_anonymise.pl which should be set up by your system administrator.
  • @@ -403,14 +403,14 @@ [% END %] - If Yes, holds placed by patrons of this category will not be given priority +
    If Yes, holds placed by patrons of this category will not be given priority
  • [% IF ( EnhancedMessagingPreferences ) %]
    -

    Default messaging preferences for this patron category

    + Default messaging preferences for this patron category [% INCLUDE 'messaging-preference-form.inc' %]
    [% END %] -- 2.11.0