From 229873632141b65b17b9dd3ca7be45d53bc77769 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Tue, 25 May 2021 18:09:30 +0300 Subject: [PATCH] Bug 22690: (QA follow-up) Silence manually generated warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In our test setup we mock the index_records() to produce warnings like this: Koha::Item at t/db_dependent/Koha/SearchEngine/Indexer.t line 93. By wrapping all our item creations to warnings_are{} we can silence them. Signed-off-by: Joonas Kylmälä --- t/db_dependent/Koha/SearchEngine/Indexer.t | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/t/db_dependent/Koha/SearchEngine/Indexer.t b/t/db_dependent/Koha/SearchEngine/Indexer.t index 47c3910864..8a7a31661e 100755 --- a/t/db_dependent/Koha/SearchEngine/Indexer.t +++ b/t/db_dependent/Koha/SearchEngine/Indexer.t @@ -113,6 +113,10 @@ subtest 'Test indexer calls' => sub { my $item; my $item2; + my $item3; + my $item4; + my $item5; + my $item6; warnings_are{ $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, @@ -126,7 +130,16 @@ subtest 'Test indexer calls' => sub { datelastseen => '2020-11-11', replacementprice => 0 }); - } [$engine,"Koha::Item",$engine,"Koha::Item"], "index_records is called for $engine when adding an item (Item->store)"; + $item3 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + $item4 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + $item5 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + $item6 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); + } [$engine,"Koha::Item", + $engine,"Koha::Item", + $engine,"Koha::Item", + $engine,"Koha::Item", + $engine,"Koha::Item", + $engine,"Koha::Item"], "index_records is called for $engine when adding an item (Item->store)"; warnings_are{ $item->store({ skip_record_index => 1 }); } undef, "index_records is not called for $engine when adding an item (Item->store) if skip_record_index passed"; @@ -163,8 +176,6 @@ subtest 'Test indexer calls' => sub { AddReturn($item->barcode, $item->homebranch, 0, undef); } [$engine,'C4::Circulation'], "index_records is called once for $engine when calling AddReturn if item not issued"; - my $item3 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); - my $item4 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); warnings_are{ $item3->move_to_biblio($biblio2); } [$engine,"Koha::Item"], "index_records is called for $engine when moving an item to another biblio (Item->move_to_biblio)"; @@ -172,8 +183,6 @@ subtest 'Test indexer calls' => sub { $item4->move_to_biblio($biblio2, { skip_record_index => 1 }); } undef, "index_records is not called for $engine when moving an item to another biblio (Item->move_to_biblio) if skip_record_index passed"; - my $item5 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); - my $item6 = $builder->build_sample_item({biblionumber => $biblio->biblionumber}); warnings_are{ $biblio2->adopt_items_from_biblio($biblio); } [$engine,"Koha::Biblio",$engine,"Koha::Biblio"], "index_records is called for both biblios for $engine when adopting items (Biblio->adopt_items_from_biblio)"; -- 2.11.0