From 3fc8b23d8a2f5d0d240c16bc7ed9bbaf1348977e Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 27 May 2021 14:25:11 +0200 Subject: [PATCH] Bug 26734: Renamed activethemes with _activethemes There was an existing call to $self->activethemes that behave as setter: 85 $self->activethemes($activethemes); I am not sure what are the side-effects but it does not look good. It caused warning in the logs: Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 279. Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 280. Use of uninitialized value $interface in string eq at /kohadevbox/koha/C4/Templates.pm line 282. Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296. Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296. Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/C4/Templates.pm line 296 --- C4/Templates.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Templates.pm b/C4/Templates.pm index 2aeedf662e0..f42cb47fb29 100644 --- a/C4/Templates.pm +++ b/C4/Templates.pm @@ -268,10 +268,10 @@ sub themelanguage { # Select a language based on cookie, syspref available languages & browser my $lang = C4::Languages::getlanguage($query); - return activethemes($htdocs, $tmpl, $interface, $lang); + return _activethemes($htdocs, $tmpl, $interface, $lang); } -sub activethemes { +sub _activethemes { my ($htdocs, $tmpl, $interface, $lang) = @_; # Get theme -- 2.20.1